Skip to content

Add 06perms to the front end #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 12, 2017
Merged

Add 06perms to the front end #1878

merged 8 commits into from
May 12, 2017

Conversation

oalders
Copy link
Member

@oalders oalders commented May 11, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 69.437% when pulling bd4460f on oalders/permission into b5af054 on master.

@oalders oalders force-pushed the oalders/permission branch from bd4460f to 9b4e11e Compare May 12, 2017 10:19
@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 69.437% when pulling 9b4e11e on oalders/permission into b5af054 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 69.437% when pulling 0fb3937 on oalders/permission into b5af054 on master.

@oalders oalders requested a review from mickeyn May 12, 2017 13:20
@oalders
Copy link
Member Author

oalders commented May 12, 2017

This has integration tests, but no unit tests. I can add the unit tests if you'd like them.

mickeyn
mickeyn approved these changes May 12, 2017
View reviewed changes
Copy link
Contributor

@mickeyn mickeyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mickeyn mickeyn changed the title [WIP] Add 06perms to the front end Add 06perms to the front end May 12, 2017
@mickeyn mickeyn merged commit 4ae7cec into master May 12, 2017
@mickeyn mickeyn deleted the oalders/permission branch May 12, 2017 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mickeyn mickeyn mickeyn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oalders @coveralls @mickeyn