Skip to content

Fix Travis builds #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 9, 2017
Merged

Fix Travis builds #1908

merged 5 commits into from
Jun 9, 2017

Conversation

oalders
Copy link
Member

@oalders oalders commented Jun 6, 2017 •
edited
Loading

The changes involving Test::Vars can be removed once we've upgraded to perl 5.26.0 See
houseabsolute/p5-Test-Vars#33

@coveralls
Copy link

Coverage Status

Coverage remained the same at 52.893% when pulling c11bd77 on oalders/skip-test-vars.t into 4f92929 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 52.893% when pulling 64a2fae on oalders/skip-test-vars.t into 4f92929 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+24.9%) to 77.747% when pulling aa92b7f on oalders/skip-test-vars.t into 4f92929 on master.

@oalders oalders force-pushed the oalders/skip-test-vars.t branch from aa92b7f to 0ee937b Compare June 8, 2017 02:48
@oalders oalders force-pushed the oalders/skip-test-vars.t branch from 0ee937b to e0ddcec Compare June 8, 2017 14:56
@coveralls
Copy link

Coverage Status

Coverage increased (+24.9%) to 77.753% when pulling 6a03a86 on oalders/skip-test-vars.t into 49aa33e on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+24.9%) to 77.753% when pulling 6a03a86 on oalders/skip-test-vars.t into 49aa33e on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+24.9%) to 77.753% when pulling a7cf288 on oalders/skip-test-vars.t into 49aa33e on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+24.9%) to 77.753% when pulling fda0eb4 on oalders/skip-test-vars.t into 49aa33e on master.

oalders added 2 commits June 8, 2017 13:11
@oalders
s/Config::JFDI/Config::ZOMG/
1da1513 
This is to remove warnings about Any::Moose.
@oalders
Don't use Carton cache when there's no cpanfile.snapshot
97378aa 
Change PERL_CARTON_PATH in Travis config.

Make sure cpm installs to correct directory when not using snapshot

Move no-snapshot lib to build dir.

Use more env vars in Travis config
@oalders oalders force-pushed the oalders/skip-test-vars.t branch from fda0eb4 to 97378aa Compare June 8, 2017 17:15
@coveralls
Copy link

Coverage Status

Coverage increased (+24.9%) to 77.753% when pulling f3404e2 on oalders/skip-test-vars.t into 49aa33e on master.

@oalders oalders requested review from haarg and mickeyn June 8, 2017 17:31
@coveralls
Copy link

Coverage Status

Coverage increased (+24.9%) to 77.753% when pulling f3404e2 on oalders/skip-test-vars.t into 49aa33e on master.

@oalders oalders changed the title Ignore file which Test::Vars chokes on. Fix Travis builds Jun 9, 2017
mickeyn
mickeyn approved these changes Jun 9, 2017
View reviewed changes
Copy link
Contributor

@mickeyn mickeyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Love the Config change 👍

@mickeyn mickeyn merged commit 5cce45b into master Jun 9, 2017
@mickeyn mickeyn deleted the oalders/skip-test-vars.t branch June 9, 2017 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mickeyn mickeyn mickeyn approved these changes

@haarg haarg Awaiting requested review from haarg

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oalders @coveralls @mickeyn