Skip to content

Trim leading and trailing whitespace from search query #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 30, 2017
Merged

Trim leading and trailing whitespace from search query #1937

merged 3 commits into from
Jun 30, 2017

Conversation

zakame
Copy link
Contributor

@zakame zakame commented Jun 30, 2017

Fixes #1621.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 76.467% when pulling 1bca1d2 on zakame:trim_leading_and_trailing_whitespace_from_search into 1da2e25 on metacpan:master.

haarg
haarg requested changes Jun 30, 2017
View reviewed changes
lib/MetaCPAN/Web/Controller/Search.pm Outdated
$query =~ s{\.pm\b}{};
}

# trim leading/traling whitespace
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this comment be removed or fixed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now removed

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 76.467% when pulling acf436c on zakame:trim_leading_and_trailing_whitespace_from_search into 1da2e25 on metacpan:master.

@zakame
Remove comment
c5a3e5a 
On second thought, its redundant.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 76.467% when pulling c5a3e5a on zakame:trim_leading_and_trailing_whitespace_from_search into 1da2e25 on metacpan:master.

@haarg haarg merged commit 9c864d7 into metacpan:master Jun 30, 2017
@zakame
Copy link
Contributor Author

zakame commented Jun 30, 2017

Thanks!

@zakame zakame deleted the trim_leading_and_trailing_whitespace_from_search branch June 30, 2017 11:59
@neilb
Copy link
Contributor

neilb commented Jun 30, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haarg haarg haarg requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zakame @coveralls @neilb @haarg