Release Info refactor #1946
Merged
Release Info refactor #1946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haarg
force-pushed
the
haarg/release-info-refactor
branch
from
34479d1 to
bfab1dc
Compare
This merges the ReleaseInfo role's logic into the ReleaseInfo model, and allows it to give all of the relevant release info at once. This removes the need to have goofy shared functions to massage the data, or insert it into the stash. It also allows the parallelism of the release info requests to be controlled easier.
haarg
force-pushed
the
haarg/release-info-refactor
branch
from
bfab1dc to
eb904bc
Compare
oalders
approved these changes
Jul 14, 2017
| return $ret; | ||
| } | ||
|
|
||
| my $rt_cpan_base = 'https://rt.cpan.org/Ticket/Display.html?id='; |
There was a problem hiding this comment.
Any reason we didn't want to have all of this logic living in a model?
There was a problem hiding this comment.
It kind of feels like it doesn't belong there, since it is display logic. I wasn't sure really about where it should be, but ReleaseInfo would be the appropriate model if it was on that level.
There was a problem hiding this comment.
Actually I misread your comment. I was considering moving this into ReleaseInfo, but I wasn't certain yet if I wanted to do that. But it can also be addressed separately.
There was a problem hiding this comment.
I was just curious. I thought it might be easier to test in a model and I think it got pulled from a model into the controller.
haarg
force-pushed
the
haarg/release-info-refactor
branch
from
eb904bc to
342faa8
Compare
mickeyn
approved these changes
Jul 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor of release info fetching and collection. Error handling not yet complete.