Skip to content

improve changelog date parsing #1972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2017
Merged

improve changelog date parsing #1972

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 42 additions & 3 deletions lib/MetaCPAN/Web/Model/API/Changes/Parser.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,45 @@ package MetaCPAN::Web::Model::API::Changes::Parser;
use Moose;
use version qw();

use CPAN::Changes;
my %months;
my $m = 0;
$months{$_} = ++$m for qw( Jan Feb Mar Apr May Jun Jul Aug Sep Oct Nov Dec );
my $months = join '|', keys %months;

our $W3CDTF_REGEX = qr{
(\d\d\d\d) # Year
(?:
[-/](\d\d|$months) # -Month
(?:
[-/](\d\d) # -Day
(?:
[T\s]
(\d\d):(\d\d) # Hour:Minute
(?:
:(\d\d) # :Second
(\.\d+)? # .Fractional_Second
)?
(
Z # UTC
| [+-]\d\d:\d\d # Hour:Minute TZ offset
(?::\d\d)? # :Second TZ offset
)?
)?
)?
)?
}x;

our $UNKNOWN_VALS = join(
'|',
(
'Unknown Release Date',
'Unknown',
'Not Released',
'Development Release',
'Development',
'Developer Release',
)
);

sub load {
my ( $class, $file ) = @_;
Expand Down Expand Up @@ -42,7 +77,7 @@ sub parse {
if ($note) {

# unknown dates
if ( $note =~ s{^($CPAN::Changes::UNKNOWN_VALS)}{}i ) {
if ( $note =~ s{^($UNKNOWN_VALS)}{}i ) {
$date = $1;
}

Expand Down Expand Up @@ -94,8 +129,12 @@ sub parse {
}

# start with W3CDTF, ignore rest
elsif ( $note =~ s{^($CPAN::Changes::W3CDTF_REGEX)}{} ) {
elsif ( $note =~ s{^($W3CDTF_REGEX)}{} && defined $3 ) {
$date = $1;
my $month = $3;
if ( $month =~ /\D/ ) {
$date =~ s{$month}{sprintf "%02d", $months{$month}}e;
}
$date =~ s{ }{T};

# Add UTC TZ if date ends at H:M, H:M:S or H:M:S.FS
Expand Down