You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't ready to go - it isn't tested, there aren't migrations made - but I thought I'd open up a PR for review. I have a few design questions tagged as #FIXME (three total).
Plus I have a general question of whether the DB design makes the internal API too complex to read or too costly to perform.
Whenever you're ready @mashton (no rush! I cannot stress that enough) I've got two things for you to look at:
the HTTP APIs are available to view in core/views.py. They're a bit janky right now, I can clean them up, but want your feedback first. I thought about using serializers here but I think if we are going to use serializers they should be within the internal API so we don't have to do everything twice. see 1c55974
I've got a very rough stab at incorporating the internal API into the oauth workflow for Slack specifically (with some of the logic abstracted into the base Plugin model). see 7307079
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't ready to go - it isn't tested, there aren't migrations made - but I thought I'd open up a PR for review. I have a few design questions tagged as #FIXME (three total).
Plus I have a general question of whether the DB design makes the internal API too complex to read or too costly to perform.