✨ Add Support for Ironic Basic auth in deployment templates #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maelk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
approved
|
The tests here will not pass until the metal3-dev-env modifications are done |
maelk
force-pushed
the
basic-auth-mael
branch
from
48bdf5b
to
c66045f
Compare
maelk
changed the title
|
/test-integration |
maelk
force-pushed
the
basic-auth-mael
branch
from
c66045f
to
f5ffef3
Compare
|
/test golint |
maelk
force-pushed
the
basic-auth-mael
branch
from
f5ffef3
to
cb75ec3
Compare
This commit modifies the config folder to deploy BMO with a custom CA cert to interact with Ironic. The CA cert must be provided as a base64 encoded string without line wrap in the IRONIC_CA_CERT_B64 environment variable for clusterctl
maelk
force-pushed
the
basic-auth-mael
branch
3 times, most recently
from
cf42849
to
0e46e8f
Compare
|
/test-integration |
maelk
force-pushed
the
basic-auth-mael
branch
from
0e46e8f
to
a90514a
Compare
|
/test-integration |
|
/lgtm |
|
/retest |
Author: maelk <mael.kimmerlin@est.tech> Date: Fri Sep 18 10:09:29 2020 +0300
namnx228
force-pushed
the
basic-auth-mael
branch
from
a90514a
to
04f3853
Compare
|
/test-integration |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support for basic authentication towards Ironic and Ironic inspector.
Based on #133