Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Remove v1alpha2 types #164

Merged
merged 1 commit into from
Mar 17, 2021
Merged

⚠️ Remove v1alpha2 types #164

merged 1 commit into from
Mar 17, 2021

Conversation

fmuyassarov
Copy link
Member

@fmuyassarov fmuyassarov commented Feb 26, 2021 •
edited
Loading

What this PR does / why we need it:
Remove v1alpha2 types.
Fixes: #159

@metal3-io-bot metal3-io-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 26, 2021
@fmuyassarov
Copy link
Member Author

/test generate

@fmuyassarov
Copy link
Member Author

/cc @maelk
/cc @furkatgofurov7
/cc @dhellmann

@fmuyassarov
Copy link
Member Author

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2021
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmuyassarov, maelk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2021
@fmuyassarov
Copy link
Member Author

/test-integration

@kashifest
Copy link
Member

kashifest commented Mar 1, 2021 •
edited
Loading

lgtm, waiting for the CI to pass

@fmuyassarov
Copy link
Member Author

/test-integration

furkatgofurov7
furkatgofurov7 reviewed Mar 1, 2021
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests have passed now, so merging it.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2021
@kashifest
Copy link
Member

/test-centos-integration

@furkatgofurov7 furkatgofurov7 mentioned this pull request Mar 2, 2021
Merged
@furkatgofurov7
Copy link
Member

/test-centos-integration

@fmuyassarov
Copy link
Member Author

fmuyassarov commented Mar 3, 2021 •
edited
Loading

PLEASE DON'T MERGE THIS.

We are going to have lazy consensus of two weeks to check if there are any objections on this.

  1. Update on the Metal3 mailing list has been sent
  2. Update on the slack has been sent

@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2021
@fmuyassarov
Copy link
Member Author

/test golint

@fmuyassarov
Copy link
Member Author

/test generate

@fmuyassarov
Remove v1alpha2 types
b2cbd5f 
Remove v1alpha2 types
@fmuyassarov
Copy link
Member Author

/test golint

@fmuyassarov
Copy link
Member Author

/test-integration

@furkatgofurov7
Copy link
Member

furkatgofurov7 commented Mar 17, 2021 •
edited
Loading

PLEASE DON'T MERGE THIS.

We are going to have lazy consensus of two weeks to check if there are any objections on this.

1. Update on the Metal3 [mailing list](https://groups.google.com/u/1/g/metal3-dev/c/b58TApTm7AA) has been sent

2. Update on the [slack](https://kubernetes.slack.com/archives/CHD49TLE7/p1614764044053600) has been sent

Since the agreed lazy consensus date reached and there were no objections AFAIK, this should be safe to merge.

@fmuyassarov leaving it up to you to unhold.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2021
@fmuyassarov
Copy link
Member Author

/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2021
@fmuyassarov
Copy link
Member Author

/test golint

@fmuyassarov
Copy link
Member Author

/test unit

@metal3-io-bot metal3-io-bot merged commit 841ab05 into metal3-io:master Mar 17, 2021
@fmuyassarov fmuyassarov deleted the remove-v1a2/feruz branch May 3, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@maelk maelk maelk approved these changes

@dhellmann dhellmann Awaiting requested review from dhellmann

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unsupported v1alpha2
5 participants
@fmuyassarov @metal3-io-bot @kashifest @furkatgofurov7 @maelk