Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add envsubst and gomock to hack/tools/go.mod #207

Merged
merged 2 commits into from
May 20, 2021
Merged

🌱 Add envsubst and gomock to hack/tools/go.mod #207

merged 2 commits into from
May 20, 2021

Conversation

wgslr
Copy link
Member

@wgslr wgslr commented May 10, 2021 •
edited
Loading

What this PR does / why we need it:
Fixes Makefile targets for building tool binaries, broken by a 'go mod tidy' run in a recent PR.

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 10, 2021
kashifest
kashifest approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please take care of the failed generate test

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, wgslr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 10, 2021
@kashifest
Copy link
Member

/test-integration
/test-centos-integration
/test-v1a3-integration
/test-v1a3-centos-integration

@wgslr
Copy link
Member Author

wgslr commented May 10, 2021

/test-v1a3-centos-integration

@wgslr wgslr force-pushed the fix/add-envsubst-to-go-mod-wgslr branch from 0ea1f00 to a8c55f1 Compare May 10, 2021 14:21
@metal3-io-bot metal3-io-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 10, 2021
@wgslr
Copy link
Member Author

wgslr commented May 12, 2021

/test unit
/test golint

@wgslr wgslr force-pushed the fix/add-envsubst-to-go-mod-wgslr branch 2 times, most recently from ea6a3e0 to 1360739 Compare May 12, 2021 08:48
@wgslr
Copy link
Member Author

wgslr commented May 12, 2021

/test-integration

@wgslr
Copy link
Member Author

wgslr commented May 17, 2021

/test-v1a3-integration
/test-v1a3-centos-integration

@fmuyassarov
Copy link
Member

/test-v1a3-integration

@fmuyassarov
Copy link
Member

/test-v1a3-centos-integration

5 similar comments
@fmuyassarov
Copy link
Member

/test-v1a3-centos-integration

@fmuyassarov
Copy link
Member

/test-v1a3-centos-integration

@fmuyassarov
Copy link
Member

/test-v1a3-centos-integration

@fmuyassarov
Copy link
Member

/test-v1a3-centos-integration

@fmuyassarov
Copy link
Member

/test-v1a3-centos-integration

@wgslr
Copy link
Member Author

wgslr commented May 18, 2021

/test-integration
/test-centos-integration
/test-v1a3-integration
/test-v1a3-centos-integration

@wgslr
Add envsubst and gomock to hack/tools/go.mod
7ccf7fc 
This fixes Makefile targets for building the tool binaries.

Prevent future removal of those entries by 'go mod tidy' by creating a
fictitious import in tools.go.

Use gomock version 1.5.0 to match the top-level go.mod file.
Regenerate baremetal/mocks due to differences between 1.4.3 and 1.5.0
(generated methods are sorted).
@wgslr wgslr force-pushed the fix/add-envsubst-to-go-mod-wgslr branch from 1360739 to ae2d06f Compare May 18, 2021 13:40
@wgslr
Copy link
Member Author

wgslr commented May 18, 2021

/test-integration
/test-centos-integration
/test-v1a3-integration
/test-v1a3-centos-integration

This was referenced May 19, 2021
Closed
Closed
@wgslr
Uplift golangc-lint to v1.40.0 in hack/tools/go.mod
48de806 
Add a configuration file to ignore staticheck error SA1019 about
deprecated types, which was not present when using older linter
versions.
@wgslr wgslr force-pushed the fix/add-envsubst-to-go-mod-wgslr branch from ae2d06f to 48de806 Compare May 20, 2021 07:44
@wgslr
Copy link
Member Author

wgslr commented May 20, 2021

/test-integration
/test-centos-integration

furkatgofurov7
furkatgofurov7 reviewed May 20, 2021
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2021
@metal3-io-bot metal3-io-bot merged commit 41a83f9 into metal3-io:master May 20, 2021
@furkatgofurov7 furkatgofurov7 mentioned this pull request Jun 16, 2021
Merged
@kashifest kashifest deleted the fix/add-envsubst-to-go-mod-wgslr branch June 20, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@kashifest kashifest kashifest approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wgslr @metal3-io-bot @kashifest @fmuyassarov @furkatgofurov7