Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Parameterize the CAPI and CAPM3 version in the e2e config file #243

Merged

Conversation

namnx228
Copy link
Member

@namnx228 namnx228 commented Jul 7, 2021

What this PR does / why we need it:
This PR makes the CAPI and CAPM3 versions defined in e2e config file the same with the version we use to setup the management cluster.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 7, 2021
@namnx228
Copy link
Member Author

namnx228 commented Jul 7, 2021

/test-integration
/test-v1a5-e2e
/assign @furkatgofurov7
/cc @wgslr

@wgslr
Copy link
Member

wgslr commented Jul 7, 2021

The e2e changes look good to me, but why is it a merge commit and has the removal of dhellmann in the diff?

@namnx228 namnx228 force-pushed the Parameterize-CAPI-CAPM3-release branch from 4aa2455 to 2473427 Compare July 7, 2021 13:25
@namnx228
Copy link
Member Author

namnx228 commented Jul 7, 2021

The e2e changes look good to me, but why is it a merge commit and has the removal of dhellmann in the diff?

Ouch, good catch. Fixed. Thanks

@namnx228
Copy link
Member Author

namnx228 commented Jul 7, 2021

/test-integration
/test-v1a5-e2e

test/e2e/config/e2e_conf.yaml Outdated Show resolved Hide resolved
test/e2e/config/e2e_conf.yaml Outdated Show resolved Hide resolved
@namnx228 namnx228 force-pushed the Parameterize-CAPI-CAPM3-release branch from 2473427 to 622bd8e Compare July 7, 2021 13:33
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 7, 2021
@namnx228 namnx228 force-pushed the Parameterize-CAPI-CAPM3-release branch from 622bd8e to db1f8b8 Compare July 7, 2021 13:34
@namnx228
Copy link
Member Author

namnx228 commented Jul 7, 2021

/test-integration
/test-v1a5-e2e

@furkatgofurov7
Copy link
Member

From the CI e2e test logs:

`INFO: Waiting for control plane to be ready
INFO: Waiting for the remaining control plane machines managed by metal3/test1 to be provisioned
STEP: Waiting for all control plane nodes to exist
INFO: Failed to list the machines: Get "https://127.0.0.1:34607/apis/cluster.x-k8s.io/v1alpha3/namespaces/metal3/machines?labelSelector=cluster.x-k8s.io%2Fcluster-name%3Dtest1%2Ccluster.x-k8s.io%2Fcontrol-plane%3D": EOF
INFO: Failed to list the machines: Get "https://127.0.0.1:34607/apis/cluster.x-k8s.io/v1alpha3/namespaces/metal3/machines?labelSelector=cluster.x-k8s.io%2Fcluster-name%3Dtest1%2Ccluster.x-k8s.io%2Fcontrol-plane%3D": EOF
INFO: Failed to list the machines: Get "https://127.0.0.1:34607/apis/cluster.x-k8s.io/v1alpha3/namespaces/metal3/machines?labelSelector=cluster.x-k8s.io%2Fcluster-name%3Dtest1%2Ccluster.x-k8s.io%2Fcontrol-plane%3D": EOF
INFO: Got error while streaming logs for pod capi-webhook-system/capm3-controller-manager-6f4d595bff-j8khd, container kube-rbac-proxy: http2: server sent GOAWAY and closed the connection; LastStreamID=3917, ErrCode=NO_ERROR, debug=""
INFO: Got error while streaming logs for pod capi-webhook-system/capi-kubeadm-bootstrap-controller-manager-7cd999d68c-dvtnv, container kube-rbac-proxy: http2: server sent GOAWAY and closed the connection; LastStreamID=3917, ErrCode=NO_ERROR, debug=""
INFO: Got error while streaming logs for pod capi-webhook-system/capi-kubeadm-control-plane-controller-manager-5f94c6cc46-5kkrw, container manager: http2: server sent GOAWAY and closed the connection; LastStreamID=3917, ErrCode=NO_ERROR, debug=""
INFO: Got error while streaming logs for pod capi-webhook-system/capm3-ipam-controller-manager-686f54975c-vbhmz, container kube-rbac-proxy: http2: server sent GOAWAY and closed the connection; LastStreamID=3917, ErrCode=NO_ERROR, debug=""
INFO: Got error while streaming logs for pod capm3-system/capm3-controller-manager-6d4ddddc65-52vk8, container kube-rbac-proxy: http2: server sent GOAWAY and closed the connection; LastStreamID=3917, ErrCode=NO_ERROR, debug=""
INFO: Got error while streaming logs for pod capi-webhook-system/capm3-ipam-controller-manager-686f54975c-vbhmz, container kube-rbac-proxy: http2: server sent GOAWAY and closed the connection; LastStreamID=3917, ErrCode=NO_ERROR, debug=""
INFO: Got error while streaming logs for pod capi-webhook-system/capi-controller-manager-5bfbf6dcfd-h5m5d, container kube-rbac-proxy: http2: server sent GOAWAY and closed the connection; LastStreamID=3917, ErrCode=NO_ERROR, debug=""
INFO: Got error while streaming logs for pod capi-webhook-system/capi-kubeadm-control-plane-controller-manager-5f94c6cc46-5kkrw, container kube-rbac-proxy: http2: server sent GOAWAY and closed the connection; LastStreamID=3917, ErrCode=NO_ERROR, debug=""
INFO: Got error while streaming logs for pod capi-webhook-system/capm3-controller-manager-6f4d595bff-j8khd, container manager: http2: server sent GOAWAY and closed the connection; LastStreamID=3917, ErrCode=NO_ERROR, debug=""
INFO: Got error while streaming logs for pod capm3-system/capm3-controller-manager-6d4ddddc65-52vk8, container kube-rbac-proxy: http2: server sent GOAWAY and closed the connection; LastStreamID=3917, ErrCode=NO_ERROR, debug=""
INFO: Got error while streaming logs for pod capi-kubeadm-bootstrap-system/capi-kubeadm-bootstrap-controller-manager-6fd7bb7948-lz4hc, container kube-rbac-proxy: http2: server sent GOAWAY and closed the connection; LastStreamID=3917, ErrCode=NO_ERROR, debug=""
INFO: Got error while streaming logs for pod capi-system/capi-controller-manager-8645d98955-nmgt8, container kube-rbac-proxy: http2: server sent GOAWAY and closed the connection; LastStreamID=3917, ErrCode=NO_ERROR, debug=""
INFO: Got error while streaming logs for pod capm3-system/capm3-baremetal-operator-controller-manager-7fd6769dc5-vb7wt, container kube-rbac-proxy: http2: server sent GOAWAY and closed the connection; LastStreamID=3917, ErrCode=NO_ERROR, debug=""
INFO: Got error while streaming logs for pod capi-webhook-system/capm3-ipam-controller-manager-686f54975c-vbhmz, container manager: http2: server sent GOAWAY and closed the connection; LastStreamID=3917, ErrCode=NO_ERROR, debug=""
INFO: Got error while streaming logs for pod capi-kubeadm-control-plane-system/capi-kubeadm-control-plane-controller-manager-657796cdc9-49h8m, container kube-rbac-proxy: http2: server sent GOAWAY and closed the connection; LastStreamID=3917, ErrCode=NO_ERROR, debug=""
INFO: Got error while streaming logs for pod capm3-system/capm3-ipam-controller-manager-6b77b87b46-2drcg, container kube-rbac-proxy: http2: server sent GOAWAY and closed the connection; LastStreamID=3917, ErrCode=NO_ERROR, debug=""
INFO: Got error while streaming logs for pod capi-webhook-system/capm3-controller-manager-6f4d595bff-j8khd, container manager: http2: server sent GOAWAY and closed the connection; LastStreamID=3917, ErrCode=NO_ERROR, debug=""
INFO: Got error while streaming logs for pod capm3-system/capm3-ipam-controller-manager-6b77b87b46-2drcg, container kube-rbac-proxy: http2: server sent GOAWAY and closed the connection; LastStreamID=3917, ErrCode=NO_ERROR, debug=""
INFO: Got error while streaming logs for pod capi-webhook-system/capi-controller-manager-5bfbf6dcfd-h5m5d, container manager: http2: server sent GOAWAY and closed the connection; LastStreamID=3917, ErrCode=NO_ERROR, debug=""
INFO: Got error while streaming logs for pod capm3-system/capm3-ipam-controller-manager-6b77b87b46-2drcg, container kube-rbac-proxy: http2: server sent GOAWAY and closed the connection; LastStreamID=3917, ErrCode=NO_ERROR, debug=""
INFO: Got error while streaming logs for pod capi-webhook-system/capm3-controller-manager-6f4d595bff-j8khd, container kube-rbac-proxy: http2: server sent GOAWAY and closed the connection; LastStreamID=3917, ErrCode=NO_ERROR, debug=""
INFO: Got error while streaming logs for pod capi-webhook-system/capi-kubeadm-bootstrap-controller-manager-7cd999d68c-dvtnv, container manager: http2: server sent GOAWAY and closed the connection; LastStreamID=3917, ErrCode=NO_ERROR, debug=""
INFO: Got error while streaming logs for pod capm3-system/capm3-controller-manager-6d4ddddc65-52vk8, container kube-rbac-proxy: http2: server sent GOAWAY and closed the connection; LastStreamID=3917, ErrCode=NO_ERROR, debug=""
INFO: Got error while streaming logs for pod capi-webhook-system/capm3-ipam-controller-manager-686f54975c-vbhmz, container manager: http2: server sent GOAWAY and closed the connection; LastStreamID=3917, ErrCode=NO_ERROR, debug=""
INFO: Failed to list the machines: an error on the server ("") has prevented the request from succeeding (get machines.cluster.x-k8s.io)`

which I have not seen in previous runs. Even though it passed, re-triggering the test to double check if it is one time flake or something is going wrong with these changes.

/test-v1a5-e2e

@furkatgofurov7
Copy link
Member

/test-v1a5-e2e

Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was one time flake, should be fine now.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2021
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furkatgofurov7, lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jan-est
Copy link
Contributor

jan-est commented Jul 8, 2021

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2021
@metal3-io-bot metal3-io-bot merged commit fab2d76 into metal3-io:master Jul 8, 2021
@kashifest kashifest deleted the Parameterize-CAPI-CAPM3-release branch August 23, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants