-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Parameterize the CAPI and CAPM3 version in the e2e config file #243
🐛 Parameterize the CAPI and CAPM3 version in the e2e config file #243
Conversation
/test-integration |
The e2e changes look good to me, but why is it a merge commit and has the removal of dhellmann in the diff? |
4aa2455
to
2473427
Compare
Ouch, good catch. Fixed. Thanks |
/test-integration |
2473427
to
622bd8e
Compare
622bd8e
to
db1f8b8
Compare
/test-integration |
From the CI e2e test logs:
which I have not seen in previous runs. Even though it passed, re-triggering the test to double check if it is one time flake or something is going wrong with these changes. /test-v1a5-e2e |
/test-v1a5-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was one time flake, should be fine now.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furkatgofurov7, lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What this PR does / why we need it:
This PR makes the CAPI and CAPM3 versions defined in e2e config file the same with the version we use to setup the management cluster.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #