🐛 Use the infrastructure components built by m3-dev-env #293
Conversation
|
/assign @furkatgofurov7 |
namnx228
force-pushed
the
use-m3-dev-env-infrastructure-component-nam
branch
from
5f8e5cf
to
edccdfc
Compare
|
/test-integration |
1 similar comment
|
/test-integration |
namnx228
force-pushed
the
use-m3-dev-env-infrastructure-component-nam
branch
from
edccdfc
to
9ec699c
Compare
|
/test-integration |
|
/test-integration |
namnx228
force-pushed
the
use-m3-dev-env-infrastructure-component-nam
branch
from
9ec699c
to
eb35120
Compare
|
/test-integration |
namnx228
force-pushed
the
use-m3-dev-env-infrastructure-component-nam
branch
from
eb35120
to
88ad58a
Compare
metal3-io-bot
added
size/M
namnx228
force-pushed
the
use-m3-dev-env-infrastructure-component-nam
branch
from
88ad58a
to
2e9e462
Compare
|
/test-integration |
|
/test-v1a5-centos-e2e |
namnx228
force-pushed
the
use-m3-dev-env-infrastructure-component-nam
branch
from
2e9e462
to
43b6b7e
Compare
|
/test-integration |
namnx228
force-pushed
the
use-m3-dev-env-infrastructure-component-nam
branch
from
43b6b7e
to
c728364
Compare
metal3-io-bot
added
size/S
|
/test-integration |
|
/test-v1a5-e2e |
namnx228
force-pushed
the
use-m3-dev-env-infrastructure-component-nam
branch
from
c728364
to
24b580f
Compare
|
/test-integration |
| @@ -31,6 +31,11 @@ export CONTROL_PLANE_MACHINE_COUNT='${CONTROL_PLANE_MACHINE_COUNT}' | |||
| # shellcheck disable=SC2016 | |||
| export WORKER_MACHINE_COUNT='${WORKER_MACHINE_COUNT}' | |||
|
|
|||
| # The e2e test framework would itself handle the cloning. It clones all the repos that are cloned in M3-DEV-ENV expect CAPM3. | |||
There was a problem hiding this comment.
maybe:
| # The e2e test framework would itself handle the cloning. It clones all the repos that are cloned in M3-DEV-ENV expect CAPM3. | |
| # The e2e test framework would itself handle the cloning. It clones all the repos that are cloned in M3-DEV-ENV except CAPM3. |
?
| # Golang needs to be installed before cloning the needed repos to the Go source directory. | ||
| make install_requirements configure_host | ||
| # shellcheck disable=SC1091 | ||
| source lib/common.sh |
There was a problem hiding this comment.
I wonder if this is needed, we do source it in prev. step (01_* and 02_* scripts), no?
There was a problem hiding this comment.
Yes, it is needed, otherwise it will fail. I have tested it.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furkatgofurov7, Rozzii, smoshiur1237 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
/lgtm |
Currently, with e2e tests, the source cluster infrastructure components are initialized by the file made by m3-dev-env, while the target cluster uses the file that is built by the test framework itself. This causes a mismatch between the source and the target cluster.
This PR makes the e2e test framework use the infrastructure components issued by m3-dev-env, leading to the consistency between the source and target clusters.
Note: By default, m3-dev-env clones CAPM3 repo from upstream and build the infrastructure components from here. This behavior is not what we want in an e2e test because the components should be built from the local CAPM3 repo when the test is executed. Therefore, this PR switches the toggle that prevents m3-dev-env to clone repos. The test framework would copy the local CAPM3 repo and clone other repos to the directory where the dev-env works with. By doing that, m3-dev-env should build the infra components based on the local CAPM3 repo.