🐛 Use patch helper to update BMH #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
approved
Using the updateObject function was triggering an infinite loop, as the metal3machine were reconciled when BMH were updated and the reconciliation was always updating the BMH
metal3-io-bot
added
size/XXL
|
/test-v1a4-integration |
|
/cc @fmuyassarov |
metal3-io-bot
added
size/L
|
/test-v1a4-integration |
| } | ||
|
|
||
| // GetBaremetalHostID return the provider identifier for this machine | ||
| func (m *MachineManager) GetBaremetalHostID(ctx context.Context) (*string, error) { | ||
| // look for associated BMH | ||
| host, err := m.getHost(ctx) | ||
| host, _, err := m.getHost(ctx) |
There was a problem hiding this comment.
is blank identifier replacing helper ?
There was a problem hiding this comment.
yes, because helper is unused here
| func (m *MachineManager) getHost(ctx context.Context) (*bmh.BareMetalHost, error) { | ||
| return getHost(ctx, m.Metal3Machine, m.client, m.Log) | ||
| func (m *MachineManager) getHost(ctx context.Context) (*bmh.BareMetalHost, *patch.Helper, error) { | ||
| host, err := getHost(ctx, m.Metal3Machine, m.client, m.Log) |
There was a problem hiding this comment.
why m.Log is needed here?
There was a problem hiding this comment.
because getHost function uses it to log some messages
jan-est
approved these changes
May 27, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jan-est, maelk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Using the updateObject function was triggering an infinite loop,
as the metal3machine were reconciled when BMH were updated and
the reconciliation was always updating the BMH
Which issue(s) this PR fixes:
Fixes #79