🏃 refactor code to replace bmm by m3m #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maelk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
approved
metal3-io-bot
added
size/L
|
/test-v1a4-integration |
|
/cc @kashifest |
metal3-io-bot
requested review from
fmuyassarov,
Jaakko-Os,
jan-est and
kashifest
fmuyassarov
reviewed
May 27, 2020
| Namespace: "myns", | ||
| }, | ||
| } | ||
| } | ||
|
|
||
| func consumerRef() *corev1.ObjectReference { | ||
| return &corev1.ObjectReference{ | ||
| Name: "mybmmachine", | ||
| Name: "mym3machine", | ||
| Namespace: "myns", | ||
| Kind: "BMMachine", |
There was a problem hiding this comment.
Should the value of Kind: be kept as is?
There was a problem hiding this comment.
thanks, I replaced only bmm, so I updated the patch to change BMM also
metal3-io-bot
added
size/XL
|
Another XL PR, but it is only a search and replace, so should be quite straightforward to review. Sorry for that |
|
/test-v1a4-integration |
|
lgtm |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR does a bit of code refactoring