-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix bug when cluster is not found #97
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maelk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @kashifest |
And remove the restrictions on the events triggering the reconciliation frommetal3dataclaim to catch update events when the deletion timestamp is set
/test-v1a4-integration |
1 similar comment
/test-v1a4-integration |
/test-v1a4-integration |
if util.IsPaused(cluster, capm3DataTemplate) { | ||
metadataLog.Info("reconciliation is paused for this object") | ||
return ctrl.Result{Requeue: true, RequeueAfter: requeueAfter}, nil | ||
if capm3DataTemplate.Spec.ClusterName != "" && cluster.Name != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we not checking this cluster != nil
condition here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because the cluster is already defined, just with empty values, so cluster would never be nil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What this PR does / why we need it:
And remove the restrictions on the events triggering the reconciliation
frommetal3dataclaim to catch update events when the deletion timestamp is
set. It also improves slightly the makefile