Move ironic into cluster

[stbenjam]

This deploys the Ironic containers in the cluster itself, rather than
the provisioning host. The provisioning host still maintains an httpd
server for hosting a cache of the IPA images, as well as any additional
images the user wants to provision with (by default we populate it with
CentOS).

Goes with metal3-io/baremetal-operator#309

fixes #41

[hardys]

Thoughts?

Unless the downloading needs to be cluster-hosted as well it seems potentially simpler to download directly onto the host, then either run httpd natively, or run a container with httpd that mounts the host directory with the images?

[stbenjam]

Thoughts?

Unless the downloading needs to be cluster-hosted as well it seems potentially simpler to download directly onto the host, then either run httpd natively, or run a container with httpd that mounts the host directory with the images?

@hardys We want the IPA images to be downloaded in the cluster though, right? I made the ipa-image-downloader an init container. I feel like it's kind of nice that all those bits are all hosted in one place.

Could we run two different http servers for metal3-dev-env? The one on the provisioning host would be for a user to dump any provisioning images they want in (and we prepopulate it with CentOS).

[hardys]

@hardys We want the IPA images to be downloaded in the cluster though, right?

Well, it's not essential but yes - note we can use CACHEURL to point the ipa downloader container at the host, so we don't download the RDO tarball every run which will save some time/bandwidth.

[stbenjam]

Ah good point about CACHEURL. I've put the httpd container back on the provisioning host, so we can grab centos there. IPA is still downloaded from within the cluster. I think this looks closer to how we did things with OpenShift.

Should be ready for a look, along with metal3-io/baremetal-operator#309

[russellb]

/test-centos-integration

[stbenjam]

/test-centos-integration

[stbenjam]

/test-centos-integration

[stbenjam]

/test-centos-integration

[stbenjam]

/test-centos-integration

[maelk]

To fix the interface issue, something similar to #71 can be done

[stbenjam]

/test-centos-integration

[russellb]

/test-centos-integration

[stbenjam]

/test-centos-integration

[stbenjam]

/test-integration

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [stbenjam]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[stbenjam]

/test-centos-integration

[stbenjam]

/test-integration

[stbenjam]

Last CI run passed: https://jenkins.nordix.org/job/airship_metal3io_metal3_dev_env_integration_test_ubuntu/34/

https://jenkins.nordix.org/job/airship_metal3io_metal3_dev_env_integration_test_centos/27/

I've squashed everything, and moved the code back to hitting metal3-io/baremetal-operator instead of my fork.

[maelk]

Some checks could be added on the ironic setup, for the configmap and secret. For the deployment there is no need as this will be checked using the check_k8s_entity since the name does not change.

[russellb]

merged the baremetal-operator PR, so let's run CI on this one more time ...

/test-centos-integration

[russellb]

@stbenjam Can you prepare a docs PR against metal3-io/metal3-io.github.io that reflects the changes to how you would talk to the Ironic API? See the "try it" page contents.

[stbenjam]

/test-centos-integration

[russellb]

/hold

Just seeing if prow is listening now ...

[russellb]

Yay

/hold cancel

[stbenjam]

/test-integration

[stbenjam]

/test-integration

[maelk]

Can we merge this ? Metal3-dev-env is broken without this.

[stbenjam]

@maelk Sure, I think so, anything else we can address in follow-ups. If you do /lgtm tide should merge this automatically

[maelk]

/lgtm