Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump shellcheck to v0.10.0 #405

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Mar 8, 2024

Shellcheck had its first release since 2022, so bump it.

Shellcheck had its first release since 2022, so bump it.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@tuminoid
Copy link
Member Author

tuminoid commented Mar 8, 2024

/hold
Needs project-infra as well.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2024
Copy link

netlify bot commented Mar 8, 2024

Deploy Preview for metal3io-website ready!

Name Link
🔨 Latest commit 1407696
🔍 Latest deploy log https://app.netlify.com/sites/metal3io-website/deploys/65eb06647d2fef00086378da
😎 Deploy Preview https://deploy-preview-405--metal3io-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 8, 2024
@kashifest
Copy link
Member

/approve

@tuminoid
Copy link
Member Author

tuminoid commented Mar 8, 2024

/unhold
Project-infra has gone in.
/test shellcheck

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2024
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2024
@tuminoid
Copy link
Member Author

tuminoid commented Mar 8, 2024

/cc @elfosardo

@elfosardo
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo, kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2024
@metal3-io-bot metal3-io-bot merged commit 6013808 into metal3-io:source Mar 8, 2024
8 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/bump-shellcheck branch March 8, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants