(SI Brochure, URGENT) Brochure: Duplicate years on rendered CIPM/CGPM references

[manuelfuenmayor]

In relation to metanorma/bipm-si-brochure#145

From metanorma/bipm-si-brochure#168, this markup:

* [[[CR1968-7, CGPM Resolution 1967-07]]]

Renders:

[ronaldtse]

@opoudjis @andrew2net is this a Relaton BIPM issue, or a Metanorma issue?

[ronaldtse]

According to the data file, the year is already included in the "ID":
https://github.com/relaton/relaton-data-bipm/blob/d40968792b9fc8e90aefc23f6921e9c74dec1ae4/data/cgpm/resolution/1967-07.yaml#L22

Is this a Relaton BIPM rendering issue? @andrew2net

[opoudjis]

We're doubling up clearly on #164.

• I actioned advice from BIPM that the year was to be added to the citation, but is a distinct thing from the identifier; so I added it on top of the ID
• @andrew2net, acting on the same advice, added the year to the ID

@ronaldtse Given the ambiguity we have already discussed for these resolutions, whose numbering restarts each year, I will have to assume that all BIPM Resolutions/Recommendations/Decisions have the year attached to the ID (@andrew2net please confirm), and I will undo the change adding the year to the ID.

[opoudjis]

At the moment, BIPM CGPM Resolution 1967-07 has a year in its ID, and BIPM CGPM Resolution 1 (or: 1889) does not: https://github.com/relaton/relaton-data-bipm/blob/d40968792b9fc8e90aefc23f6921e9c74dec1ae4/data/cgpm/resolution/1.yaml . However, this is being addressed by @andrew2net . So I am removing any injection of years into citations of Resolutions/Recommendations/Decisions, that is @andrew2net's responsibility, not mine.

[opoudjis]

Note that PR will not currently work, because I am waiting for year to be added to BIPM CGPM Resolution 1 and BIPM CIPM Decision 105.

[ronaldtse]

@andrew2net this is an issue in Relaton-BIPM.

The raw data seems to be correct:

• CGPM Resolution 1: https://github.com/metanorma/bipm-data-outcomes/blob/59a48683f130986f3834d0a10c54e6ff9da20789/cgpm/meetings-en/meeting-01.yml#L9-L15
• CIPM Decision 105 (@opoudjis has fixed it, there is no actual "Decision 105".)

[ronaldtse]

@opoudjis , "CGPM Resolution (1889)" already has year :
https://github.com/relaton/relaton-data-bipm/blob/7b3460028d0c064ecb6743f6cb4c075136d7bc46/data/cgpm/meetings/resolution/1889-00.yaml#L22

[opoudjis]

PR has passed. This should now be fine. Yes, I know they already have years, that is a fix as of relaton-bipm 1.1.3. That's why I'm no longer adding them.