Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate IETF area/workgroup information into static data here #1

Closed
ronaldtse opened this issue Jul 11, 2021 · 10 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@ronaldtse
Copy link

We have to move the content of IETF area/workgroup lists to this new location.

Basically this content needs to be moved into GitHub Actions in this current repo:
https://github.com/metanorma/metanorma-ietf/blob/79f3c0faae12be4ae7852b2ecd6b6c968fe8122f/lib/asciidoctor/ietf/validate.rb#L37-L90

We can use a GHA workflow with cron to update the data here.

Corresponding issue in metanorma-ietf:
metanorma/metanorma-ietf#156

@ronaldtse
Copy link
Author

Ping @CAMOBAP @andrew2net would you be free to do this? I wonder if @andrew2net has more experience with this.

@CAMOBAP CAMOBAP self-assigned this Jul 21, 2021
@ronaldtse ronaldtse added the enhancement New feature or request label Jul 21, 2021
@CAMOBAP
Copy link
Contributor

CAMOBAP commented Jul 21, 2021

I'm ready to take it

@ronaldtse @opoudjis maybe you can point to similar data gem ? Should it just contain json or some extra logic too?

@ronaldtse
Copy link
Author

@CAMOBAP Just JSON or YAML would be great. Only content, no logic needed here. The logic is to be updated in the metanorma-ietf code.

CAMOBAP added a commit that referenced this issue Jul 26, 2021
CAMOBAP added a commit that referenced this issue Jul 26, 2021
CAMOBAP added a commit that referenced this issue Jul 26, 2021
@CAMOBAP
Copy link
Contributor

CAMOBAP commented Jul 26, 2021

  • first gem pushed
  • check_update workflow implemented, I will check how it works

Moving to metanorma/metanorma-ietf#156 and will close once check_update` workflow passed

@ronaldtse
Copy link
Author

@CAMOBAP Thanks! Just checking to see if there would be an issue with packed-mn on this line:

File.join(File.dirname(__FILE__), "workgroups.json"),

@ronaldtse
Copy link
Author

@CAMOBAP also, we do want to have a non-Gem format of data because it allows non-Ruby code to also fetch that information.

@CAMOBAP
Copy link
Contributor

CAMOBAP commented Jul 27, 2021

@ronaldtse https://raw.githubusercontent.com/metanorma/metanorma-ietf-data/main/lib/metanorma/ietf/data/workgroups.json is always available for such purpose. Let me know if there is a better way to accomplish this

@CAMOBAP
Copy link
Contributor

CAMOBAP commented Jul 27, 2021

Thanks! Just checking to see if there would be an issue with packed-mn on this line

@ronaldtse good catch but! I didn't think about it.

I think it should not because we use Ruby's API for file manipulation i.e. File.read which is memfs-aware

@CAMOBAP
Copy link
Contributor

CAMOBAP commented Nov 18, 2021

looks complete

@CAMOBAP CAMOBAP closed this as completed Nov 18, 2021
@ronaldtse
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants