add types to the exports field in package.json #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typescript 4.7+ with `moduleResolution: node16` reads the types from the exports field
🦋 Changeset detectedLatest commit: 20e13b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Any chance to merge this PR and publish a new release? |
|
@lorisleiva We would appreciate this PR to be merged and released. It's blocking us from migrating to ESM with TypeScript 5.x. |
raymondfeng
approved these changes
Sep 17, 2023
|
Hi there, could you add a |
|
@lorisleiva I've added a changeset, doing a patch bump since to my knowledge, the types field in the exports shouldn't affect existing projects. But a minor bump might be appropriate if I'm wrong about that. |
lorisleiva
approved these changes
Sep 18, 2023
febo
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typescript 4.7+ with
moduleResolution: node16reads the types from the exports field