Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editable Auctions #44

Closed
bhgames opened this issue Jun 16, 2021 · 1 comment
Closed

Editable Auctions #44

bhgames opened this issue Jun 16, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@bhgames
Copy link
Contributor

bhgames commented Jun 16, 2021

An auction should have an is_mutable flag that can only be set on creation. If this isn't set, the auction is immutable, which provides stability and certainty to those auctions because the people bidding in them know that auction cannot change, be deleted, or what have you. It's a different mindset, that we'd like to preserve as a toggle. I suspect it won't be used often after we introduce this feature though.

If it is set, then the auctioneer can:

  • Change ended_at
  • Change gap_time
  • Change the tick size
  • Change the price floor (but not invalidate current bids that got on before the price floor)

And finally:

  • Hide the auction by moving it to a new deleted state. This only is workable if last_bid is empty. This is for "accidental" auctions.

The UI will need to be modified to only show deleted auctions to people who created them (fairly easy filter to add) and to people who have bid in them so they can refund bids, and the is_winner logic will need updates to consider an auction in this state as having zero winners, which is an interface leak since bid_state doesn't know about it, but it's parent container object (auction) does. This is fine since bid_state isn;'t directly called but the parent wrapper method is, so the logic can be there.

This may also cause issues due to the issue we have with borsh + adding new fields to AuctionData, so a lot of these new fields will need to go on AuctionDataExtended. Be aware.

@bhgames bhgames added the enhancement New feature or request label Jun 16, 2021
@jordaaash
Copy link
Contributor

Closed as stale per discussion with @bhgames.

austbot pushed a commit that referenced this issue Dec 7, 2021
* feat(packs): redeeming

* feat: add probability to cards in pack (#32)

* dummy modal component (#33)

* fix an ability to close modal (#34)

* fix: fetch editions on pack page

* fix: re-fetch data on visiting artworks page

fix: pull items page typing

fix: hide initial store modal

fix: build issues

return websockets

drop websockets

clean-up

* refactor: clean-up

* feat: remove packs from homepage (#36)

* feat: merge voucher metadata with pack (#37)

* fix: instruction chunks to optimize packs creation (#38)

* refactor: remove websockets

* fix: build

* refactor: remove unneded fetch

* fix: fetch item that is redeemed

* feat: Add limit of cards per pack (#40)

* fix: revert meta use effect

* feat: update transactions due to program changes

* fix: build and clean-up

* chore: update CHANGELOG.md

* chore: update CHANGELOG

* feat: extend pack details view with voucher (#41)

* feat: redesign pack card (#42)

* feat: updated pack card

* fix: comments fixed

* fix: packs layout on small screens (#43)

* fix: hotfix create art view card (#44)

* feat: remove opening pack after click (#45)

* feat: remove pack card animation (#46)

* feat: remove animation from packs (#47)

* feat: new open pack button (#48)

* fix: less compilation

* refactor: pack page always has editionId (#49)

* feat: implement request cards as a single transaction. (#50)

* fix: build

* feat: create action to request cards (#51)

* fix: auctions cards UI layout (#52)

* feat: modal for redeemed cards (#53)

* feat: redeem pack modal

* fix: small refactor

* fix: comments fixed

* fix: refactor after comments

* feat: implement full pack size claim (#54)

* feat: modal for approve transactions explanation (#55)

* feat: added approve transaction step

* fix: comments fixed

* refactor: remove unused component

* feat: update logic of packs displaying in My Items section (#56)

* feat: Use Context to store pack state (#58)

* fix: import

* fix: styles

* fix: style variable

* fix: fetch pack state after redeem (#59)

* Merge master from foundation

* fix: packs feature flag

* feat: pack page mobile view (#57)

* fix: build

* feat: partially open pack (#62)

* feat: mobile view for claim pack modal (#63)

* feat: provide random oracle in transactions (#64)

* fix: redeemed cards list is wrong (#65)

Co-authored-by: Paul <5280742+kurpav@users.noreply.github.com>
Co-authored-by: ViacheslavMylostyvyi <gamer2forse@gmail.com>
Co-authored-by: Irina Kadushkina <69786983+ikadushkina@users.noreply.github.com>
austbot pushed a commit that referenced this issue Dec 8, 2021
* feat(packs): redeeming

* feat: add probability to cards in pack (#32)

* dummy modal component (#33)

* fix an ability to close modal (#34)

* fix: fetch editions on pack page

* fix: re-fetch data on visiting artworks page

fix: pull items page typing

fix: hide initial store modal

fix: build issues

return websockets

drop websockets

clean-up

* refactor: clean-up

* feat: remove packs from homepage (#36)

* feat: merge voucher metadata with pack (#37)

* fix: instruction chunks to optimize packs creation (#38)

* refactor: remove websockets

* fix: build

* refactor: remove unneded fetch

* fix: fetch item that is redeemed

* feat: Add limit of cards per pack (#40)

* fix: revert meta use effect

* feat: update transactions due to program changes

* fix: build and clean-up

* chore: update CHANGELOG.md

* chore: update CHANGELOG

* feat: extend pack details view with voucher (#41)

* feat: redesign pack card (#42)

* feat: updated pack card

* fix: comments fixed

* fix: packs layout on small screens (#43)

* fix: hotfix create art view card (#44)

* feat: remove opening pack after click (#45)

* feat: remove pack card animation (#46)

* feat: remove animation from packs (#47)

* feat: new open pack button (#48)

* fix: less compilation

* refactor: pack page always has editionId (#49)

* feat: implement request cards as a single transaction. (#50)

* fix: build

* feat: create action to request cards (#51)

* fix: auctions cards UI layout (#52)

* feat: modal for redeemed cards (#53)

* feat: redeem pack modal

* fix: small refactor

* fix: comments fixed

* fix: refactor after comments

* feat: implement full pack size claim (#54)

* feat: modal for approve transactions explanation (#55)

* feat: added approve transaction step

* fix: comments fixed

* refactor: remove unused component

* feat: update logic of packs displaying in My Items section (#56)

* feat: Use Context to store pack state (#58)

* fix: import

* fix: styles

* fix: style variable

* fix: fetch pack state after redeem (#59)

* Merge master from foundation

* fix: packs feature flag

* feat: pack page mobile view (#57)

* fix: build

* feat: partially open pack (#62)

* feat: mobile view for claim pack modal (#63)

* feat: provide random oracle in transactions (#64)

* fix: redeemed cards list is wrong (#65)

* feat: update pack opening resume

Co-authored-by: Paul <5280742+kurpav@users.noreply.github.com>
Co-authored-by: ViacheslavMylostyvyi <gamer2forse@gmail.com>
Co-authored-by: Irina Kadushkina <69786983+ikadushkina@users.noreply.github.com>
nikkaroraa pushed a commit to tech-guides/metaplex that referenced this issue Jan 22, 2022
* feat(packs): redeeming

* feat: add probability to cards in pack (metaplex-foundation#32)

* dummy modal component (metaplex-foundation#33)

* fix an ability to close modal (metaplex-foundation#34)

* fix: fetch editions on pack page

* fix: re-fetch data on visiting artworks page

fix: pull items page typing

fix: hide initial store modal

fix: build issues

return websockets

drop websockets

clean-up

* refactor: clean-up

* feat: remove packs from homepage (metaplex-foundation#36)

* feat: merge voucher metadata with pack (metaplex-foundation#37)

* fix: instruction chunks to optimize packs creation (metaplex-foundation#38)

* refactor: remove websockets

* fix: build

* refactor: remove unneded fetch

* fix: fetch item that is redeemed

* feat: Add limit of cards per pack (metaplex-foundation#40)

* fix: revert meta use effect

* feat: update transactions due to program changes

* fix: build and clean-up

* chore: update CHANGELOG.md

* chore: update CHANGELOG

* feat: extend pack details view with voucher (metaplex-foundation#41)

* feat: redesign pack card (metaplex-foundation#42)

* feat: updated pack card

* fix: comments fixed

* fix: packs layout on small screens (metaplex-foundation#43)

* fix: hotfix create art view card (metaplex-foundation#44)

* feat: remove opening pack after click (metaplex-foundation#45)

* feat: remove pack card animation (metaplex-foundation#46)

* feat: remove animation from packs (metaplex-foundation#47)

* feat: new open pack button (metaplex-foundation#48)

* fix: less compilation

* refactor: pack page always has editionId (metaplex-foundation#49)

* feat: implement request cards as a single transaction. (metaplex-foundation#50)

* fix: build

* feat: create action to request cards (metaplex-foundation#51)

* fix: auctions cards UI layout (metaplex-foundation#52)

* feat: modal for redeemed cards (metaplex-foundation#53)

* feat: redeem pack modal

* fix: small refactor

* fix: comments fixed

* fix: refactor after comments

* feat: implement full pack size claim (metaplex-foundation#54)

* feat: modal for approve transactions explanation (metaplex-foundation#55)

* feat: added approve transaction step

* fix: comments fixed

* refactor: remove unused component

* feat: update logic of packs displaying in My Items section (metaplex-foundation#56)

* feat: Use Context to store pack state (metaplex-foundation#58)

* fix: import

* fix: styles

* fix: style variable

* fix: fetch pack state after redeem (metaplex-foundation#59)

* Merge master from foundation

* fix: packs feature flag

* feat: pack page mobile view (metaplex-foundation#57)

* fix: build

* feat: partially open pack (metaplex-foundation#62)

* feat: mobile view for claim pack modal (metaplex-foundation#63)

* feat: provide random oracle in transactions (metaplex-foundation#64)

* fix: redeemed cards list is wrong (metaplex-foundation#65)

Co-authored-by: Paul <5280742+kurpav@users.noreply.github.com>
Co-authored-by: ViacheslavMylostyvyi <gamer2forse@gmail.com>
Co-authored-by: Irina Kadushkina <69786983+ikadushkina@users.noreply.github.com>
nikkaroraa pushed a commit to tech-guides/metaplex that referenced this issue Jan 22, 2022
* feat(packs): redeeming

* feat: add probability to cards in pack (metaplex-foundation#32)

* dummy modal component (metaplex-foundation#33)

* fix an ability to close modal (metaplex-foundation#34)

* fix: fetch editions on pack page

* fix: re-fetch data on visiting artworks page

fix: pull items page typing

fix: hide initial store modal

fix: build issues

return websockets

drop websockets

clean-up

* refactor: clean-up

* feat: remove packs from homepage (metaplex-foundation#36)

* feat: merge voucher metadata with pack (metaplex-foundation#37)

* fix: instruction chunks to optimize packs creation (metaplex-foundation#38)

* refactor: remove websockets

* fix: build

* refactor: remove unneded fetch

* fix: fetch item that is redeemed

* feat: Add limit of cards per pack (metaplex-foundation#40)

* fix: revert meta use effect

* feat: update transactions due to program changes

* fix: build and clean-up

* chore: update CHANGELOG.md

* chore: update CHANGELOG

* feat: extend pack details view with voucher (metaplex-foundation#41)

* feat: redesign pack card (metaplex-foundation#42)

* feat: updated pack card

* fix: comments fixed

* fix: packs layout on small screens (metaplex-foundation#43)

* fix: hotfix create art view card (metaplex-foundation#44)

* feat: remove opening pack after click (metaplex-foundation#45)

* feat: remove pack card animation (metaplex-foundation#46)

* feat: remove animation from packs (metaplex-foundation#47)

* feat: new open pack button (metaplex-foundation#48)

* fix: less compilation

* refactor: pack page always has editionId (metaplex-foundation#49)

* feat: implement request cards as a single transaction. (metaplex-foundation#50)

* fix: build

* feat: create action to request cards (metaplex-foundation#51)

* fix: auctions cards UI layout (metaplex-foundation#52)

* feat: modal for redeemed cards (metaplex-foundation#53)

* feat: redeem pack modal

* fix: small refactor

* fix: comments fixed

* fix: refactor after comments

* feat: implement full pack size claim (metaplex-foundation#54)

* feat: modal for approve transactions explanation (metaplex-foundation#55)

* feat: added approve transaction step

* fix: comments fixed

* refactor: remove unused component

* feat: update logic of packs displaying in My Items section (metaplex-foundation#56)

* feat: Use Context to store pack state (metaplex-foundation#58)

* fix: import

* fix: styles

* fix: style variable

* fix: fetch pack state after redeem (metaplex-foundation#59)

* Merge master from foundation

* fix: packs feature flag

* feat: pack page mobile view (metaplex-foundation#57)

* fix: build

* feat: partially open pack (metaplex-foundation#62)

* feat: mobile view for claim pack modal (metaplex-foundation#63)

* feat: provide random oracle in transactions (metaplex-foundation#64)

* fix: redeemed cards list is wrong (metaplex-foundation#65)

* feat: update pack opening resume

Co-authored-by: Paul <5280742+kurpav@users.noreply.github.com>
Co-authored-by: ViacheslavMylostyvyi <gamer2forse@gmail.com>
Co-authored-by: Irina Kadushkina <69786983+ikadushkina@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants