Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the type of endSettings #1662

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Conversation

halaprix
Copy link
Contributor

The type of endSettings has been wrong, making it impossible to use the endSettings outside the candy-machine.ts.

It was :
endSettings: null || [number, anchor.BN]

Corrected to :

endSettings: null | { number: anchor.BN; endSettingType: any };

Console output:
image

@vercel
Copy link

vercel bot commented Jan 27, 2022

@halaprix is attempting to deploy a commit to the Metaplex Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jan 27, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

candy-machine-ui – ./js/packages/candy-machine-ui

🔍 Inspect: https://vercel.com/metaplex/candy-machine-ui/4sng1xsFh1BrRs1zgEoeN713kBu3
✅ Preview: https://candy-machine-ui-git-fork-halaprix-patch-1-metaplex.vercel.app

@vercel vercel bot temporarily deployed to Preview – candy-machine-ui January 27, 2022 10:22 Inactive
@stegaBOB stegaBOB merged commit 1ab5279 into metaplex-foundation:master Feb 4, 2022
vamise added a commit to vamise/nft-marketplace that referenced this pull request Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants