metasfresh/metasfresh-webui-frontend-legacy#487 when quick input is n…

…ot editable return 404

to avoid showing "weird" exception to use, so we return HTTP 404 which
is interpreted by frontend

metasfresh-webui-api/src/main/java/de/metas/ui/web/exceptions/EntityNotFoundException.java

@@ -1,6 +1,8 @@
 package de.metas.ui.web.exceptions;
 
+import org.adempiere.ad.callout.exceptions.CalloutInitException;
 import org.adempiere.exceptions.AdempiereException;
+import org.adempiere.util.Check;
 import org.springframework.http.HttpStatus;
 import org.springframework.web.bind.annotation.ResponseStatus;
 
@@ -38,8 +40,31 @@
 @ResponseStatus(code = HttpStatus.NOT_FOUND)
 public class EntityNotFoundException extends AdempiereException
 {
+	public static final EntityNotFoundException wrapIfNeeded(final Throwable throwable)
+	{
+		Check.assumeNotNull(throwable, "throwable not null");
+
+		if (throwable instanceof CalloutInitException)
+		{
+			return (EntityNotFoundException)throwable;
+		}
+
+		final Throwable cause = extractCause(throwable);
+		if(cause != throwable)
+		{
+			return wrapIfNeeded(cause);
+		}
+
+		return new EntityNotFoundException(extractMessage(throwable), cause);
+	}
+
 	public EntityNotFoundException(final String message)
 	{
 		super(message);
 	}
+
+	public EntityNotFoundException(final String message, final Throwable cause)
+	{
+		super(message, cause);
+	}
 }

metasfresh-webui-api/src/main/java/de/metas/ui/web/quickinput/WindowQuickInputRestController.java

@@ -152,12 +152,21 @@ public JSONDocument create(
 
 				final QuickInputDescriptor quickInputDescriptor = quickInputDescriptors.getQuickInputEntityDescriptor(includedDocumentDescriptor);
 
-				return QuickInput.builder()
-						.setQuickInputDescriptor(quickInputDescriptor)
-						.setRootDocumentPath(rootDocument.getDocumentPath())
-						.build()
-						.bindRootDocument(rootDocument)
-						.assertTargetWritable();
+				try
+				{
+					return QuickInput.builder()
+							.setQuickInputDescriptor(quickInputDescriptor)
+							.setRootDocumentPath(rootDocument.getDocumentPath())
+							.build()
+							.bindRootDocument(rootDocument)
+							.assertTargetWritable();
+				}
+				catch(Exception ex)
+				{
+					// Avoid showing "weird" exception to use, so we return HTTP 404 which is interpreted by frontend
+					// see https://github.com/metasfresh/metasfresh-webui-frontend/issues/487
+					throw EntityNotFoundException.wrapIfNeeded(ex);
+				}
 			});
 
 			commit(quickInput);