MenuNode: tolerate AD_Menu_ID=0

#446
metasfresh · Jun 9, 2017 · 76a3c3a · 76a3c3a
1 parent 559cc96
commit 76a3c3a
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/main/java/de/metas/ui/web/menu/MenuNode.java b/src/main/java/de/metas/ui/web/menu/MenuNode.java
@@ -324,7 +324,7 @@ public boolean isMatchedByFilter()
 
 	public static final class Builder
 	{
-		private int adMenuId;
+		private int adMenuId = -1;
 
 		private String caption;
 		private String captionBreadcrumb;
@@ -352,7 +352,9 @@ public Builder setAD_Menu_ID(final int adMenuId)
 
 		private int getAD_Menu_ID()
 		{
-			if (adMenuId <= 0)
+			// NOTE: tolerate adMenuId=0 because there are some case in old API where we have a MTreeNode with Node_ID=0 (usually the root)
+			// see https://github.com/metasfresh/metasfresh-webui-api/issues/446
+			if (adMenuId < 0)
 			{
 				throw new AdempiereException("AD_Menu_ID not set");
 			}