Skip to content

Commit

Permalink
picking terminal: don't show already shipped HUs
Browse files Browse the repository at this point in the history
  • Loading branch information
teosarca committed Oct 26, 2017
1 parent 66c7606 commit 88cbf2b
Showing 1 changed file with 9 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import org.adempiere.exceptions.AdempiereException;
import org.adempiere.util.GuavaCollectors;
import org.adempiere.util.Services;
import org.compiere.model.IQuery;
import org.springframework.stereotype.Service;

import com.google.common.annotations.VisibleForTesting;
Expand All @@ -23,6 +24,7 @@

import de.metas.handlingunits.model.I_M_HU;
import de.metas.handlingunits.model.I_M_Picking_Candidate;
import de.metas.handlingunits.model.X_M_HU;
import de.metas.handlingunits.model.X_M_Picking_Candidate;
import de.metas.handlingunits.picking.IHUPickingSlotDAO;
import de.metas.handlingunits.sourcehu.SourceHUsService;
Expand Down Expand Up @@ -174,6 +176,13 @@ private static List<I_M_Picking_Candidate> retrievePickingCandidates(@NonNull fi
Check.errorIf(true, "Query has unexpected pickingCandidates={}; query={}", pickingSlotRowQuery.getPickingCandidates(), pickingSlotRowQuery);
}

//
// HU filter
final IQuery<I_M_HU> husQuery = queryBL.createQueryBuilder(I_M_HU.class)
.addNotEqualsFilter(I_M_HU.COLUMNNAME_HUStatus, X_M_HU.HUSTATUS_Shipped) // not already shipped (https://github.com/metasfresh/metasfresh-webui-api/issues/647)
.create();
queryBuilder.addInSubQueryFilter(I_M_Picking_Candidate.COLUMN_M_HU_ID, I_M_HU.COLUMN_M_HU_ID, husQuery);

return queryBuilder
.create()
.list();
Expand Down

0 comments on commit 88cbf2b

Please sign in to comment.