Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dashboard: support "position" when PATCHing a dashboard item #486

Closed
teosarca opened this issue Jun 30, 2017 · 2 comments
Closed

dashboard: support "position" when PATCHing a dashboard item #486

teosarca opened this issue Jun 30, 2017 · 2 comments
Labels
branch:master branch:release priority:high type:enhancement

Comments

@teosarca
Copy link
Member

Is this a bug or feature request?

Feature request

What is the current behavior?

Following PATCHing endpoints does not support "position" path:

What is the expected or desired behavior?

Those endpoints shall support "position" because this is how the frontend was delivered.

NOTE: it seems the frontend it's not used the endpoints which were previously built to change KPI or target indicators order. I think we shall deprecated/remove those endpoints:

Note to IT

Test the frontend task: metasfresh/metasfresh-webui-frontend-legacy#905
teosarca added a commit that referenced this issue Jun 30, 2017
@teosarca
dashboard: support "position" when PATCHing a dashboard item
e4b821c 
#486
teosarca added a commit that referenced this issue Jun 30, 2017
@teosarca
dashboard: drop unused API
535beae 
#486
@teosarca teosarca mentioned this issue Jun 30, 2017
Closed
teosarca added a commit that referenced this issue Jun 30, 2017
@teosarca
fixing compile error related to lombok 1.16.16
4885c53 
#486

might be related to projectlombok/lombok#1302
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Jun 30, 2017
@metas-ts
Update ReleaseNotes.md
902a746 
[#905](metasfresh/metasfresh-webui-frontend-legacy#905) Add/ Remove KPI Widget functionality for User Dashboard
[#486](metasfresh/metasfresh-webui-api-legacy#486) dashboard: support "position" when PATCHing a dashboard item
[#482](metasfresh/metasfresh-webui-api-legacy#482) No Role Error for new User
[#481](metasfresh/metasfresh-webui-api-legacy#481) Sticky empty Filter in modal overlay.
[#485](metasfresh/metasfresh-webui-api-legacy#485) backend: refactor sticky filters
[#949](metasfresh/metasfresh-webui-frontend-legacy#949) Board: adding a card as last is not user friendly]
[#469](metasfresh/metasfresh-webui-api-legacy#469) Picking prototype (v2)
[#923](metasfresh/metasfresh-webui-frontend-legacy#923) Packageables window: up/down arrows are working weird
[#945](metasfresh/metasfresh-webui-frontend-legacy#945) dashboard: react to websocket notifications
[#933](metasfresh/metasfresh-webui-frontend-legacy#933) Disable quick actions button while running the action (v2)

me.45
@teosarca
Copy link
Member Author

rolled on w101

@metas-rc
Copy link
Member

Frontend IT went fine. Moving to done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch:master branch:release priority:high type:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@teosarca @metas-ts @metas-rc