Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

dashboard: react to websocket notifications #945

Closed
teosarca opened this issue Jun 26, 2017 · 1 comment
Closed

dashboard: react to websocket notifications #945

teosarca opened this issue Jun 26, 2017 · 1 comment

Comments

@teosarca
Copy link
Member

Type of issue

Feature request

Current behavior

Modify the dashboard in one browser tab.
No other browser tabs which are showing the same dashboard are updated.

As a side effect, when you are removing a KPI, in the other browser tab you will see "error loading data" for that KPI (because backend returned "no item found").

Expected behavior

Frontend shall listen to dashboard's websocket endpoint and shall update the dashboard instantly.

The websocket endpoint is provided by one of the following endpoints:

They will contain the same "websocketEndpoint" because underthehood, on server side there is only one dashboard which defines the KPIs and Target Indicators.

The websocket events types are:

  • changeType="dashboardChanged" - fired when the dashboad was changed (item added, removed or item order changed).
  • changeType="itemChanged" - fired when a dashboard item was changed (e.g. caption, interval, when changed).

This is a follow-up of #905

@teosarca teosarca added this to the 2017-26 milestone Jun 26, 2017
@damianprzygodzki damianprzygodzki self-assigned this Jun 27, 2017
@damianprzygodzki damianprzygodzki modified the milestones: 2017-27, 2017-26 Jun 27, 2017
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Jun 30, 2017
[#905](metasfresh/metasfresh-webui-frontend-legacy#905) Add/ Remove KPI Widget functionality for User Dashboard
[#486](metasfresh/metasfresh-webui-api-legacy#486) dashboard: support "position" when PATCHing a dashboard item
[#482](metasfresh/metasfresh-webui-api-legacy#482) No Role Error for new User
[#481](metasfresh/metasfresh-webui-api-legacy#481) Sticky empty Filter in modal overlay.
[#485](metasfresh/metasfresh-webui-api-legacy#485) backend: refactor sticky filters
[#949](metasfresh/metasfresh-webui-frontend-legacy#949) Board: adding a card as last is not user friendly]
[#469](metasfresh/metasfresh-webui-api-legacy#469) Picking prototype (v2)
[#923](metasfresh/metasfresh-webui-frontend-legacy#923) Packageables window: up/down arrows are working weird
[#945](metasfresh/metasfresh-webui-frontend-legacy#945) dashboard: react to websocket notifications
[#933](metasfresh/metasfresh-webui-frontend-legacy#933) Disable quick actions button while running the action (v2)

me.45
@metas-rc
Copy link
Member

metas-rc commented Jul 4, 2017

Results of IT

Tested on mf15releasetest webui

When in edit mode, the adding and removing of KPIs works correctly on both tabs.

@metas-rc metas-rc closed this as completed Jul 4, 2017
@metas-rc metas-rc self-assigned this Jul 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants