Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Add/ Remove KPI Widget functionality for User Dashboard #905

Closed
metas-mk opened this issue Jun 17, 2017 · 15 comments
Closed

Add/ Remove KPI Widget functionality for User Dashboard #905

metas-mk opened this issue Jun 17, 2017 · 15 comments

Comments

@metas-mk
Copy link
Member

Type of issue

Feature request

Current behavior

Currently, the User Dashboard is static. The Widgets are shown and can only by moved, but not removed and not added.

Expected behavior

Similar to the new Dashboard/ Swimland Functionality, a functionality shall be provided for the user to add/ remove KPI widgets from the board.
image

@teosarca
Copy link
Member

We need to prepare the API first.

@teosarca
Copy link
Member

NOTE: as discussed, i've unified GET /kpis/available and GET /targetIndicators/available.
See metasfresh/metasfresh-webui-api-legacy#464 .
Will be available on next rollout.

@damianprzygodzki
Copy link
Contributor

damianprzygodzki commented Jun 23, 2017

From endpoints:

POST /rest/api/dashboard/targetIndicators/new
POST /rest/api/dashboard/kpis/new

I am getting:

"exception": "de.metas.ui.web.exceptions.EntityNotFoundException"

for KPIS: 1000004, and for TI: 1000002

@teosarca
Copy link
Member

checking....

teosarca added a commit to metasfresh/metasfresh-webui-api-legacy that referenced this issue Jun 23, 2017
@teosarca
Copy link
Member

fixed, shall work now.

@damianprzygodzki
Copy link
Contributor

@teosarca How can we set position of widget when adding new one?

@teosarca
Copy link
Member

metasfresh/metasfresh-webui-api-legacy#474 is rolleded out. API shall be available on w101

@teosarca
Copy link
Member

Quick checked to change KPIs order (same issue on target indicators too).

image

The problem is with that endpoint call.
When patching a KPI/target indicator, there is no "position" field. Because changing the position for one KPI implies changing the position on all others.
For that reason, the "position" path is not supported.

To change the order of KPIs or target indicators, please use:

The PATCH request body shall look like:

[
  {
    "op": "replace",
    "path": "orderedItemIds",
    "value": { itemId1, itemId2 .... itemIdLast}
  }
]

@damianprzygodzki
Copy link
Contributor

As discussed on skype: we should somehow unify board and dashboard behavior. So or we are going to use that way of replacing property "orderedItemIds", or change "position" property for both entities.

@teosarca
Copy link
Member

checking

@teosarca
Copy link
Member

UPDATE: implemented "position" support in metasfresh/metasfresh-webui-api-legacy#486
Will be available on next rollout.

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Jun 30, 2017
[#905](metasfresh/metasfresh-webui-frontend-legacy#905) Add/ Remove KPI Widget functionality for User Dashboard
[#486](metasfresh/metasfresh-webui-api-legacy#486) dashboard: support "position" when PATCHing a dashboard item
[#482](metasfresh/metasfresh-webui-api-legacy#482) No Role Error for new User
[#481](metasfresh/metasfresh-webui-api-legacy#481) Sticky empty Filter in modal overlay.
[#485](metasfresh/metasfresh-webui-api-legacy#485) backend: refactor sticky filters
[#949](metasfresh/metasfresh-webui-frontend-legacy#949) Board: adding a card as last is not user friendly]
[#469](metasfresh/metasfresh-webui-api-legacy#469) Picking prototype (v2)
[#923](metasfresh/metasfresh-webui-frontend-legacy#923) Packageables window: up/down arrows are working weird
[#945](metasfresh/metasfresh-webui-frontend-legacy#945) dashboard: react to websocket notifications
[#933](metasfresh/metasfresh-webui-frontend-legacy#933) Disable quick actions button while running the action (v2)

me.45
@metas-rc metas-rc self-assigned this Jul 4, 2017
@metas-rc
Copy link
Member

metas-rc commented Jul 4, 2017

Results of IT

Tested on mf15releasetest

Adding and removing KPI widgets works correcty in webui.
Stress-tested and had no problems either.

@metas-rc metas-rc closed this as completed Jul 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants