Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Disable quick actions button while running the action (v2) #933

Closed
teosarca opened this issue Jun 22, 2017 · 8 comments
Closed

Disable quick actions button while running the action (v2) #933

teosarca opened this issue Jun 22, 2017 · 8 comments

Comments

@teosarca
Copy link
Member

Type of issue

Bug

Current behavior

When pressing a quick action the process is started right away.
But the quick action button is green even though the process did not finish.

image

Expected behavior

The quick action button shall always be disabled while the process is running.
After the process was executed, successfully or with ANY error/exception the quick action button shall be unlocked and it's state shall be reevaluated (i.e. ask API about quick actions).

This is just a shade of this cinquecento #500 :)

@teosarca teosarca added this to the 2017-25 milestone Jun 22, 2017
@teosarca teosarca changed the title Disable quick actions button while the process is running Disable quick actions button while running the action (v2) Jun 22, 2017
@Dunkat Dunkat self-assigned this Jun 26, 2017
damianprzygodzki added a commit that referenced this issue Jun 26, 2017
Disable quick actions button while running the action (v2) #933
@cadavre cadavre modified the milestones: 2017-26, 2017-25, 2017-27 Jun 26, 2017
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Jun 30, 2017
[#905](metasfresh/metasfresh-webui-frontend-legacy#905) Add/ Remove KPI Widget functionality for User Dashboard
[#486](metasfresh/metasfresh-webui-api-legacy#486) dashboard: support "position" when PATCHing a dashboard item
[#482](metasfresh/metasfresh-webui-api-legacy#482) No Role Error for new User
[#481](metasfresh/metasfresh-webui-api-legacy#481) Sticky empty Filter in modal overlay.
[#485](metasfresh/metasfresh-webui-api-legacy#485) backend: refactor sticky filters
[#949](metasfresh/metasfresh-webui-frontend-legacy#949) Board: adding a card as last is not user friendly]
[#469](metasfresh/metasfresh-webui-api-legacy#469) Picking prototype (v2)
[#923](metasfresh/metasfresh-webui-frontend-legacy#923) Packageables window: up/down arrows are working weird
[#945](metasfresh/metasfresh-webui-frontend-legacy#945) dashboard: react to websocket notifications
[#933](metasfresh/metasfresh-webui-frontend-legacy#933) Disable quick actions button while running the action (v2)

me.45
@metas-rc metas-rc self-assigned this Jul 3, 2017
@metas-rc
Copy link
Member

metas-rc commented Jul 3, 2017

Results of IT

Tested on mf15releasetest webui

The quick actions are disabled while the process is running: OK
State is reevaluated after the process is finished and the right quickaction, disabled/enabled is displayed: OK

I found a detail problem for which I created a followup: #973

@metas-rc metas-rc closed this as completed Jul 3, 2017
metas-ts added a commit that referenced this issue Jul 4, 2017
This reverts commit 2e474fb.
Reverting commit for
#933
because it might have introduced
#974
that can be quite irritating for users
@teosarca teosarca reopened this Jul 4, 2017
@teosarca
Copy link
Member Author

teosarca commented Jul 4, 2017

reopened because @metas-ts reverted it

@metas-ts metas-ts assigned wiadev and unassigned metas-rc and Dunkat Jul 4, 2017
@wiadev
Copy link
Contributor

wiadev commented Jul 5, 2017

My observations not directly related to changes made for this story:

  1. Too much (really heavily overloaded) re-renders of components on input properties change. Probably need to review input parameter bindings and/or split into few components to optimize re-renders. There are lot of components with some 10-20 input parameters which are changed often and thus causing frequent component redraws. The only reason why it still works considerably well - thanks to React's optimized DOM manipulation.

  2. Progress indication had animation of 1s length on success, regardless of actual time spent on request. Thus you seen progress animation even while actually nothing happened at this time. I've reduced this completion animation to 0.1 second. Please confirm if this is acceptable.

  3. Progress tracking seems to be a bit overloaded. It has many of unclear parameters, like refresh, processState, indicator. They're changed asynchronously, causing too much component redraws (see item # 1 above)

@metas-ts
Copy link
Member

metas-ts commented Jul 6, 2017

rolled out on our IT server for checking prior to integration

metas-mk added a commit that referenced this issue Jul 6, 2017
Fix Disable quick actions button while running the action #933
metas-ts pushed a commit that referenced this issue Jul 6, 2017
(cherry picked from commit f576631)

solved Conflicts:
	src/components/app/QuickActions.js
@metas-ts
Copy link
Member

metas-ts commented Jul 6, 2017

cherry-picked to the release branch

@wiadev
Copy link
Contributor

wiadev commented Jul 7, 2017

@metas-ts is this still open?

@metas-ts
Copy link
Member

Hi @wiadev,
yes, still open,
but your and my part is probably done :-)
Our QA will also take a look at it and then probably close it

@metas-mk metas-mk self-assigned this Jul 11, 2017
@metas-mk
Copy link
Member

Tested. Works as required. Done/ Closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants