Add to Transportation Order, Ship and Invoice action in Picking Clearing Tray not respecting the invoice schedule

[metas-dh]

Is this a bug or feature request?

Bug

What is the current behavior?

The Add to Transportation Order, Ship and Invoice action in Picking Clearing Tray does not respect invoice schedule (follow up of #763, => invoice candidates which have a Invoice Schedule set are skipped. They will be invoiced on that schedule (e.g. monthly, weekly etc))

Which are the steps to reproduce?

1. Have a bpartner with invoice schedule e.g. 14 days, so invoice would be created on e.g. 1st and 15th of the month
2. Have picked and processed HUs for a sales order of this bpartner
3. Take out these HUs in Picking Clearing Tray, and use action "Transportation Order, Ship and Invoice"
   => invoice is created despite not being due yet according to the schedule.

What is the expected or desired behavior?

The action shall respect the invoice schedule: invoice candidates shall be skipped.

[metas-lc]

couldn't test this one because of invoice schedules were not set correctly. Created a task metasfresh/metasfresh#3498

[metas-lc]

IT

1. created new invoice schedule "Every monday" (today is thursday)
2. went to a bpartner and in tab customer i set this invoice schedule and invoice rule to Customer Schedule after Delivery
3. went to transport order and created a new one
4. created/completed a new sales order with this bpartner
5. went to picking terminal, picked the whole qty and then processed the HUs
6. went to picking tray clearing, selected my HUs and used "take out HUs"
7. selected my HUs on right side and used "Transportation Order, Ship and Invoice"
   => new inout was created OK
   => invoice was not created and date invoice from is set to next monday OK
   .
8. repeated the same testcase without invoice schedule, and invoice rule to after Delivery
   => new inout was created OK
   => i didn't get invoice (?) NOK i think
   (checked to see if i can invoice it manually, without ignoring invoice schedule and i could. but note that date invoice from was 12/31/9999, so probably because of that)
   .
9. repeated the same testcase without invoice schedule, and invoice rule to Immediate
   => new inout was created OK
   => i got 1 invoice, but only with the product NOK

[metas-lc]

IT1.2 (noticed some problems regarding the number of inouts so i'm changing a bit the testcases). IT1 is still valid and the problems should be fixed.

I. invoice schedule set on today(every friday), and invoice rule to Customer Schedule after Delivery

Regression 1

1. create/complete sales order
   => IC: Date Invoice from: 12/31/9999 OK
2. create inout from shipment schedules - create invoice from ICs
   => invoice created, with product and TU OK
   => IC: Date Invoice from: 04/27/2018 OK
   (works the same if you pick and create inout from shipment schedules using the picked qty OK)

Case 1 inout

1. create/complete sales order (with 1 TU) - create 1 inout using Picking Terminal and "Transportation Order, Ship and Invoice"
   => invoice not created NOK
   => IC: Date Invoice from: 12/31/9999 NOK

Case 2 inouts

1. create/complete sales order (with 2 TUs) - create 2 inout using Picking Terminal and "Transportation Order, Ship and Invoice"(TSI) - one by one
   => invoice created only after the second TSI and only with products. HUs are missing. NOK
   (note if helps: after you create the first inout, Date Invoice from is still 12/31/9999. After second, is set on today)

II. invoice schedule set on other day (every monday), and invoice rule to Customer Schedule after Delivery

Regression 1

1. create/complete sales order
   => IC: Date Invoice from: 12/31/9999 OK
2. create inout from shipment schedules - create invoice from ICs
   => invoice not created OK
   => IC: Date Invoice from: 04/30/2018 OK
   (works the same if you pick and create inout from shipment schedules using the picked qty OK)

Case 1 inout

1. create/complete sales order (with 1 TU) - create 1 inout using Picking Terminal and "Transportation Order, Ship and Invoice"
   => invoice not created OK
   => IC: Date Invoice from: 12/31/9999 NOK

Case 2 inouts

1. create/complete sales order (with 2 TUs) - create 2 inout using Picking Terminal and "Transportation Order, Ship and Invoice"- one by one
   => invoice not created OK
   (note if helps: after you create the first inout, Date Invoice from is still 12/31/9999. After second, is set on monday)

III. No invoice schedule and invoice rule to After Delivery

Regression 1

1. create/complete sales order
   => IC: Date Invoice from: 12/31/9999 OK
2. create inout from shipment schedules - create invoice from ICs
   => invoice created OK
   => IC: Date Invoice from: 04/27/2018 OK
   (if you pick and create inout from shipment schedules using the picked qty then IC: Date Invoice from: 12/31/9999 NOK? - after you created the inout)

Case 1 inout

1. create/complete sales order (with 1 TU) - create 1 inout using Picking Terminal and "Transportation Order, Ship and Invoice"
   => invoice not created NOK
   => IC: Date Invoice from: 12/31/9999 NOK

Case 2 inouts

1. create/complete sales order (with 2 TUs) - create 2 inout using Picking Terminal and "Transportation Order, Ship and Invoice"(TSI) - one by one
   => invoice created only after the second TSI and only with products. HUs are missing. NOK
   (note if helps: after you create the first inout, Date Invoice from is still 12/31/9999. After second, is still 12/31/9999) NOK?

IV. No invoice schedule and invoice rule to Immediate

Regression 1

1. create/complete sales order
   => IC: Date Invoice from: today OK
2. create inout from shipment schedules - create invoice from ICs
   => invoice created OK
   => IC: Date Invoice from: 04/27/2018 OK
   (works the same if you pick and create inout from shipment schedules using the picked qty OK)

Case 1 inout

1. create/complete sales order (with 1 TU) - create 1 inout using Picking Terminal and "Transportation Order, Ship and Invoice"
   => invoice created, but only with the product NOK
   => IC: Date Invoice from: today OK

Case 2 inouts

1. create/complete sales order (with 2 TUs) - create 2 inout using Picking Terminal and "Transportation Order, Ship and Invoice"(TSI) - one by one
   => invoice created only with product. HUs are missing. NOK