Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "No Handling Unit" and "Virtual PI" PIs #1501

Closed
teosarca opened this issue May 10, 2017 · 5 comments
Closed

Rename "No Handling Unit" and "Virtual PI" PIs #1501

teosarca opened this issue May 10, 2017 · 5 comments
Assignees
@metas-mk @metas-lc
Labels
branch:release bug_please_use_type:bug_instead type:enhancement
Milestone
2017-18

Comments

@teosarca
Copy link
Member

Rename as follows:

  • "No Handling Unit" => "Template PI" (or similar)
  • "Virtual PI" => "No PI" (or similar)

Reason: because that's how they are actually used ;)
@teosarca teosarca added this to the 2017-18 milestone May 10, 2017
metas-mk added a commit that referenced this issue May 15, 2017
@metas-mk
#1501 Renaming the Internal Packing Items
7b93c5f 
Renaming the Internal Packing Items so that the names describe better
what they really are.

FRESH-2204 #1501
@metas-mk metas-mk mentioned this issue May 15, 2017
Merged
metas-mk added a commit that referenced this issue May 15, 2017
@metas-mk
Update ReleaseNotes.md
d8e317e 
Adding the issue #1501 Rename "No Handling Unit" and "Virtual PI" PIs to this week's release notes.
metas-mk added a commit that referenced this issue May 15, 2017
@metas-mk
Merge pull request #1535 from metasfresh/gh1501
5eaccfa 
#1501 Renaming the Internal Packing Items
@teosarca
Copy link
Member Author

rolled out on w101

@metas-dh
Copy link
Member

metas-dh commented May 17, 2017 •
edited

Results of IT1
tested on w101 and mf15 Swing

Swing:
Wareneingang POS, Gebindekonfig:

  • former "No Handling Unit" (LU): now called "Packing Item Template": OK
  • former "Virtual PI" (TU): now called "No Packing Item": OK

Purchase Order:

  • "Virtual PI" (TU): still called "Virtual PI"??

WebUI:
material receipt schedule:

  • former "No Handling Unit" (LU): both "No Packing Item" & "Packing Item Template" available?
  • former "Virtual PI" (TU): still called Virtual PI (also in purchase order

@teosarca: is this ok?
2017-05-17 17_21_24-metasfresh

@teosarca
Copy link
Member Author

hmm, nop... we shall get rid of VirtualPI term

metas-mk added a commit that referenced this issue May 18, 2017
@metas-mk
#1501 Adding further renaming of system elements for former VirtualPI
99be122 
Adding further renaming of system elements for former VirtualPI

FRESH-2204 #1501
@metas-mk metas-mk mentioned this issue May 18, 2017
Merged
@metas-mk
Copy link
Member

Fixed. Renamed the CUTU and other elements too.

metas-mk added a commit that referenced this issue May 18, 2017
@metas-mk
Merge pull request #1576 from metasfresh/gh1501a
f9ed1a2 
#1501 Rename "No Handling Unit" and "Virtual PI" PIs
@metas-lc metas-lc self-assigned this May 24, 2017
@metas-lc
Copy link
Contributor

metas-lc commented May 24, 2017 •
edited

IT
repeated testcase above:

Swing:
Wareneingang POS, Gebindekonfig:

  • former "No Handling Unit" (LU): now called "Packing Item Template": OK
  • former "Virtual PI" (TU): now called "No Packing Item": OK

Purchase Order:

  • "Virtual PI" (TU): called "No Packing Item": OK

WebUI:
material receipt schedule:

  • former "No Handling Unit" (LU): both "No Packing Item" & "Packing Item Template" OK
  • former "Virtual PI" (TU): "No Packing Item" OK

Purchase order: "No Packing Item" OK

metas-ts added a commit that referenced this issue Feb 11, 2018
@metas-ts
Update ReleaseNotes.md
3615c27 
[#3408](#3408) New Product Window for Pharma vertical
[#3445](#3445) Qty TU not correct in purchase invoice jasper
[#829](metasfresh/metasfresh-webui-api-legacy#829) Planning status in manufacturing order not updated
[#3406](#3406) Set Selector in M_Product after Product Data Import
[#3458](#3458) Remove M_Storage-based legacy check from MProduct
[#3413](#3413) Credit Limit data structure as subtab in Businesspartner
[#1501](metasfresh/metasfresh-webui-frontend-legacy#1501) Automated Javascript and React Testing with Jest
[#818](metasfresh/metasfresh-webui-api-legacy#818) Values.valueToJsonObject() shall return JSONNullValue instead of null
[#3454](#3454) Resolve log warning "Skip setting parameter value for X_AD_PInstance_Para[0]"
[#3438](#3438) Qty LU wrong in purchase invoice candidates / invoice
[#3449](#3449) ImportHelper doesn't switch ctx
[#807](metasfresh/metasfresh-webui-api-legacy#807) Quantity to invoice override callout
[#806](metasfresh/metasfresh-webui-api-legacy#806) Add to Transportation Order, Ship and Invoice action in Picking Clearing Tray not respecting the invoice schedule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metas-mk metas-mk

@metas-lc metas-lc

Labels
branch:release bug_please_use_type:bug_instead type:enhancement
Projects
None yet
Milestone
2017-18
Development

No branches or pull requests
5 participants
@teosarca @metas-ts @metas-mk @metas-lc @metas-dh