Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Values.valueToJsonObject() shall return JSONNullValue instead of null #818

Closed
metas-ts opened this issue Feb 2, 2018 · 3 comments
Closed

Values.valueToJsonObject() shall return JSONNullValue instead of null #818

metas-ts opened this issue Feb 2, 2018 · 3 comments
Assignees
@metas-ts
Labels
branch:master branch:release type:enhancement

Comments

@metas-ts
Copy link
Member

metas-ts commented Feb 2, 2018

Is this a bug or feature request?

FR

What is the current behavior?

currently, this function might return null.
For me that's a problem, because

  • that way IVIewRow.getFieldNameAndJsonValues() does not return entries for null row values.
  • therefore, those null row values are not part of the fieldsByNamemap that is send to the frontend.
  • therefore, the respective row's viewEditorRenderMode isn't sent either
  • therefore, the frontend falls back to a parent value, which is - in my case - wrong

Note that my particular problem could be handles in other ways, but i think if we have that method and we have JSONNullValue, then let's use it to avoid returning null
@metas-ts metas-ts self-assigned this Feb 2, 2018
metas-ts added a commit that referenced this issue Feb 2, 2018
@metas-ts
make the change in Values.valueToJsonObject()
8a3a261 
the rest is jsut minor changes/cleanups etc
#818 Values.valueToJsonObject() shall return JSONNullValue instead of null
@metas-ts metas-ts mentioned this issue Feb 2, 2018
Merged
metas-ts added a commit that referenced this issue Feb 2, 2018
@metas-ts
Solve javadoc error, thx @teosarca
ced8d0a 
#818 Values.valueToJsonObject() shall return JSONNullValue instead of null
metas-ts added a commit that referenced this issue Feb 2, 2018
@metas-ts
undo an accidental change
eecb83d 
#818 Values.valueToJsonObject() shall return JSONNullValue instead of null
metas-ts added a commit that referenced this issue Feb 5, 2018
@metas-ts
Merge pull request #819 from metasfresh/gh818-api
a66d220 
#818 Values.valueToJsonObject() shall return JSONNullValue instead of null
metas-ts added a commit that referenced this issue Feb 5, 2018
@metas-ts
Avoid ClassCastException if o1 is String and o2 JSONNullValue
7c1e777 
Values.valueToJsonObject() shall return JSONNullValue instead of null
#818
metas-ts added a commit that referenced this issue Feb 5, 2018
@metas-ts
Avoid NumberFormatException when jsonValueObj is JSONNullValue
10b535c 
Values.valueToJsonObject() shall return JSONNullValue instead of null
#818
teosarca added a commit that referenced this issue Feb 5, 2018
@teosarca
go back to returning null for null on Values.valueToJsonObject()
0ee0893 
#818
@metas-ts metas-ts mentioned this issue Feb 6, 2018
Merged
metas-ts added a commit that referenced this issue Feb 6, 2018
@metas-ts
Merge pull request #823 from metasfresh/gh818webui
5d0c794 
#818 Values.valueToJsonObject() shall return JSONNullValue instead of null
metas-ts pushed a commit that referenced this issue Feb 8, 2018
@teosarca @metas-ts
go back to returning null for null on Values.valueToJsonObject()
7b208d8 
#818
(cherry picked from commit 0ee0893)
@metas-ts
Copy link
Member Author

metas-ts commented Feb 8, 2018

cherry-picked to 2018-06

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Feb 11, 2018
@metas-ts
Update ReleaseNotes.md
3615c27 
[#3408](#3408) New Product Window for Pharma vertical
[#3445](#3445) Qty TU not correct in purchase invoice jasper
[#829](metasfresh/metasfresh-webui-api-legacy#829) Planning status in manufacturing order not updated
[#3406](#3406) Set Selector in M_Product after Product Data Import
[#3458](#3458) Remove M_Storage-based legacy check from MProduct
[#3413](#3413) Credit Limit data structure as subtab in Businesspartner
[#1501](metasfresh/metasfresh-webui-frontend-legacy#1501) Automated Javascript and React Testing with Jest
[#818](metasfresh/metasfresh-webui-api-legacy#818) Values.valueToJsonObject() shall return JSONNullValue instead of null
[#3454](#3454) Resolve log warning "Skip setting parameter value for X_AD_PInstance_Para[0]"
[#3438](#3438) Qty LU wrong in purchase invoice candidates / invoice
[#3449](#3449) ImportHelper doesn't switch ctx
[#807](metasfresh/metasfresh-webui-api-legacy#807) Quantity to invoice override callout
[#806](metasfresh/metasfresh-webui-api-legacy#806) Add to Transportation Order, Ship and Invoice action in Picking Clearing Tray not respecting the invoice schedule
@metas-lc
Copy link

found related issue when you pick more than you ordered #847

@metas-rc
Copy link
Member

metas-rc commented Mar 7, 2018

Nothing to IT. Moving this to Done.

@metas-rc metas-rc closed this as completed Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metas-ts metas-ts

Labels
branch:master branch:release type:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@metas-ts @metas-rc @metas-lc