Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grid view websocket notifications: fullyChanged shall not be set when changedIds is set #151

Closed
teosarca opened this issue Feb 19, 2017 · 3 comments
Closed

grid view websocket notifications: fullyChanged shall not be set when changedIds is set #151

teosarca opened this issue Feb 19, 2017 · 3 comments
Assignees
@teosarca @metas-lc
Labels
branch:master branch:release type:bug
Milestone
2017-16

Comments

@teosarca
Copy link
Member

See: de.metas.ui.web.view.event.JSONDocumentViewChanges.JSONDocumentViewChanges(DocumentViewChanges)

Atm we are setting fullyChanged flag to true if changedIds is not empty.
We do this because we want to make #150 work until metasfresh/metasfresh-webui-frontend-legacy#355 is implemented.
@teosarca teosarca added this to the 2017-08 milestone Feb 19, 2017
@teosarca teosarca self-assigned this Feb 19, 2017
teosarca added a commit that referenced this issue Feb 19, 2017
@teosarca
#151 view websocket notifications: fullyChanged shall not be set when…
d223e6a 
… changedIds is set
@teosarca
Copy link
Member Author

see pull request #152

@metas-mk metas-mk modified the milestones: 2017-09, 2017-08 Feb 28, 2017
@metas-mk metas-mk modified the milestones: 2017-12, 2017-09 Mar 19, 2017
@teosarca teosarca mentioned this issue Mar 23, 2017
Closed
@metas-mk metas-mk modified the milestones: 2017-16, 2017-12 Apr 9, 2017
teosarca added a commit that referenced this issue Apr 24, 2017
@teosarca
grid view websocket notifications: fullyChanged shall not be set when…
1935d17 
… changedIds is set #151
@teosarca
Copy link
Member Author

Note to IT:

Test case 1.

  • open receipt candidates
  • receive some HUs & create the material receipt
  • press DONE to go back to receipt candidates view (DON'T REFRESH)
  • check the receipt candidate line: the quantities shall reflect the received HUs

Test case 2.

  • open receipt candidates
  • run the Korrectur quick actions (suppose you already received something on that line)
  • reverse some receipts
  • press DONE to go back to receipt candidates view (DON'T REFRESH)
  • check the receipt candidate line: the quantities shall be updated

@teosarca teosarca mentioned this issue Apr 24, 2017
Closed
@metas-lc metas-lc self-assigned this Apr 24, 2017
@metas-lc
Copy link

IT
Repeated testcase above:

  1. create a new purchase order, add a product, complete
  2. go to receipt candidates and receive some HUs (e.g. 4), press done
    => new receipt created
    => without refreshing, qty TU is updated to 4
  3. receive 6 TUs
    => without refreshing, qty TU is updated to 10
  4. receive 5 TUs
    => without refreshing, qty TU is updated to 15
  5. receive 1 TU
    => without refreshing, qty TU is updated to 16
  6. select Korrectur, reverse 2 receipts: the one with 4 and the one with 6
    => without refreshing, qty TU is updated to 6
  7. reverse 1 receipt: the one with 1
    => without refreshing, qty TU is updated to 5
    (while qtyTU was updated, moved qty was updated as well) OK

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Apr 28, 2017
@metas-ts
adding additional items to the RNs
015fe73 
[#1382](#1382) Make Packing Item editable in Manufacturing Order Header
[#323](metasfresh/metasfresh-webui-api-legacy#323) Manufacturing Issue/Receipt: receipt lines shall be displayed first
[#689](metasfresh/metasfresh-webui-frontend-legacy#689) Image widget is missing right border
[#326](metasfresh/metasfresh-webui-api-legacy#326) technical: Remove JSONProcessInstanceResult deprecated properties
[#680](metasfresh/metasfresh-webui-frontend-legacy#680) Navigation breadcrumb vs. Navigation Menu
[#329](metasfresh/metasfresh-webui-api-legacy#329) Issue HU 404 not found#
[#688](metasfresh/metasfresh-webui-frontend-legacy#688) Main page /dashboard is broken
[#667](metasfresh/metasfresh-webui-frontend-legacy#667) Change /rest/api/pattribute request message
[#319](metasfresh/metasfresh-webui-api-legacy#319) Manufacturing Issue/Receipt: show BOM line attributes if any
[#317](metasfresh/metasfresh-webui-api-legacy#317) Manufacturing Issue/Receipt: drop StatusInfo column
[#248](metasfresh/metasfresh-webui-frontend-legacy#248) Handle Password Fields in WebUI
[#678](metasfresh/metasfresh-webui-frontend-legacy#678) Get rid of deprecated static docNo input in header.
[#151](metasfresh/metasfresh-webui-api-legacy#151) grid view websocket notifications: fullyChanged shall not be set when changedIds is set
[#664](metasfresh/metasfresh-webui-frontend-legacy#664) process doesn't open directly
[#311](metasfresh/metasfresh-webui-api-legacy#311) Switching language does not translate document lookup values
[#310](metasfresh/metasfresh-webui-api-legacy#310) Switching language does not translate document references
[#306](metasfresh/metasfresh-webui-api-legacy#306) Address missing in 'Adresse' for bpartner created on-the-fly
[#673](metasfresh/metasfresh-webui-frontend-legacy#673) Wrong report file endpoint is called for processes which are started from main menu
[#1347](#1347) technical: ModelClassGenerator shall generate BigDecimal.ZERO instead of Env.ZERO
[#880](#880) Improve IProcessPrecondition framework
[#641](metasfresh/metasfresh-webui-frontend-legacy#641) Shortcuts behavior sometimes weird
[#644](metasfresh/metasfresh-webui-frontend-legacy#644) Creating a new Discount record error
[#649](metasfresh/metasfresh-webui-frontend-legacy#649) windowId shall be handled as a string and not as a number
[#596](metasfresh/metasfresh-webui-frontend-legacy#596) red line appears on document only after refresh
[#433](metasfresh/metasfresh-webui-frontend-legacy#433) ShipmentSchedule: Only displayed after "No data" showing up
[#270](metasfresh/metasfresh-webui-api-legacy#270) cannot add trading unit with batch entry after using add new
[#537](metasfresh/metasfresh-webui-frontend-legacy#537) KPI: implement a non intrusive way to display KPI related errors
[#268](metasfresh/metasfresh-webui-api-legacy#268) HU attributes shall always provide the WidgetType along with the data/changes
[#579](metasfresh/metasfresh-webui-frontend-legacy#579) DocumentNo field is not updated

me-45
hairy tinkerbell struck again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teosarca teosarca

@metas-lc metas-lc

Labels
branch:master branch:release type:bug
Projects
None yet
Milestone
2017-16
Development

No branches or pull requests
4 participants
@teosarca @metas-ts @metas-mk @metas-lc