frontend: Letters feature

[teosarca]

Type of issue

Feature request

Expected behavior

1. open a document, e.g. a sales order - https://w101.metasfresh.com:8443/window/143/1000257

2. click on Menu -> Letter (note: the Letter menu item shall be displayed if provided, see Render only provided document standard actions #1195 )
   

3. A letter modal is opening which is very similar with the Menu->Email modal, but much more simple:
   
   i.e.

• there is no "To" and "Topic" fields
• there are no attachments
• we still have the the templates dropdown (top right corner) which shall work like in the Email modal but instead of "/mail/" APIs, the "/letter/" APIs shall be used
• on the left side of templates dropdown we have a print preview icon (button) which when pressed it shall call /letter/{letterId}/printPreview
• on bottom we have the "Create" button. When pressed the /letter/{letterId}/complete API shall be called and if successful, the modal shall be closed
  

Notes and observations

• all texts & messages shall be acquired via /i18n/messages
• the letters API is described here: http://w101.metasfresh.com:8081/swagger-ui.html#/letter-rest-controller which is very similar with Mail API which is described here: http://w101.metasfresh.com:8081/swagger-ui.html#/mail-rest-controller

[teosarca]

The backend task is metasfresh/metasfresh-webui-api-legacy#178

[pablosichert]

Should there be a hotkey for this feature? If yes, which one?

[metas-mk]

Should there be a hotkey for this feature? If yes, which one?

@pablosichert No thanks. Not needed atm.

EDIT: Just saw that you added [ctrl]+r already. Ok, let's leave it like it is and see. ;)

[teosarca]

btw, @pablosichert the Letter menu item shall be visible only if is provided in document's standardActions, i.e.

[pablosichert]

@metas-mk Ok. I think the hotkeys could use some refactoring as well. For example I think mod + nwould be more intuitive for "New document" instead of mod + m. But that also depends how accustomed users are to the existing hotkeys.

@teosarca I put a comment on the PR regarding that. I think it would be easier to leave it hardcoded in this PR and then refactor it altogether in #1195.

[teosarca]

hi @pablosichert , thanks for the PR.

Did a quick test and found following issues.

1. (cosmetics) until we find an icon for Letter menu item i would suggest to keep the space empty and have the menu item texts aligned:
   

[teosarca]

2. The text templates dropdown is missing:
   

It shall look and work exactly like in Email panel:

[pablosichert]

Thanks for checking out the changes. I'll align the text accordingly.

The dropdown should be visible when the endpoint returns a set of templates.

Can you confirm that this is the right endpoint, but it doesn't return templates yet or is the URL wrong?

[teosarca]

shit, right :)

I forgot to add that method. I just added now and it will be available on next build/rollout.

Btw, after selecting a template, i got following warning in console. Not sure if it's OK?!

[pablosichert]

Np 😄 I'll look into it. Also fixing the margin between print preview button and dropdown at the top.

[teosarca]

done, API available: http://w101.metasfresh.com:8081/swagger-ui.html#!/letter-rest-controller/getTemplatesUsingGET

[metas-rc]

Results of IT

• OK: The letter funtionality works well. See resultsof Have Letter Feature in Sales Order Window  metasfresh-webui-api-legacy#178 for information

• The letter window closes after print preview. Followup created: The Letter window dissapears after Print Preview #1227