Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Bug in Partner window after setting Attributes (Labels) #1238

Closed
metas-rc opened this issue Oct 6, 2017 · 3 comments
Closed

Bug in Partner window after setting Attributes (Labels) #1238

metas-rc opened this issue Oct 6, 2017 · 3 comments
Assignees
@metas-rc
Labels
branch:master branch:release priority:high type:bug

Comments

@metas-rc
Copy link
Member

metas-rc commented Oct 6, 2017

Is this a bug or feature request?

  • Bug

What is the current behavior?

  • The window freezes after setting an attribute (label), moving to grid view and get to the partner again.

Which are the steps to reproduce?

  • open window /window/123/
  • open any partner
  • set one attribute (new feature)
  • go back to partner list
  • open same partner again
  • => NOK: URL changes to opened partner but window remains in grid view

The following exception is thrown in the inspection console:

RawWidget.js:700 Uncaught TypeError: Cannot read property 'values' of undefined
at RawWidget.value [as renderWidget] (RawWidget.js:700)
at RawWidget.render (RawWidget.js:720)
at ReactCompositeComponentWrapper._renderValidatedComponentWithoutOwnerOrContext (ReactCompositeComponent.js:799)
at ReactCompositeComponentWrapper._renderValidatedComponent (ReactCompositeComponent.js:822)
at ReactCompositeComponentWrapper.performInitialMount (ReactCompositeComponent.js:362)
at ReactCompositeComponentWrapper.mountComponent (ReactCompositeComponent.js:258)
at Object.mountComponent (ReactReconciler.js:46)
at ReactCompositeComponentWrapper.performInitialMount (ReactCompositeComponent.js:371)
at ReactCompositeComponentWrapper.mountComponent (ReactCompositeComponent.js:258)
at Object.mountComponent (ReactReconciler.js:46)

What is the expected or desired behavior?

  • Please, fix.
@teosarca
Copy link
Member

teosarca commented Oct 6, 2017

introduced by #1138

pablosichert added a commit that referenced this issue Oct 6, 2017
@pablosichert
Make <Labels> resilient against wrong props
326fc29 
Issue #1238
@pablosichert pablosichert mentioned this issue Oct 6, 2017
Merged
metas-ts pushed a commit that referenced this issue Oct 9, 2017
@pablosichert @metas-ts
Make <Labels> resilient against wrong props
4ce1226 
Issue #1238

(cherry picked from commit 326fc29)
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Oct 9, 2017
@metas-ts
Update ReleaseNotes.md
e28601e 
[#1238](metasfresh/metasfresh-webui-frontend-legacy#1238)
Bug in Partner window after setting Attributes (Labels)

me-45
@metas-ts
Copy link
Member

metas-ts commented Oct 9, 2017

CPed this to the release branch

@metas-rc metas-rc self-assigned this Oct 9, 2017
@metas-rc
Copy link
Member Author

metas-rc commented Oct 9, 2017

Results of IT

  • The bug was fixed. Followed the steps and all works fine
  • Did some regression testing on Partner Label widgets and database saving for the attributes and all went fine.

@metas-rc metas-rc closed this as completed Oct 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@metas-rc metas-rc

Labels
branch:master branch:release priority:high type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@teosarca @metas-ts @metas-rc @metasnw