Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Dropdown in Grid view needs two-time click again #1440

Closed
metas-dh opened this issue Dec 12, 2017 · 5 comments
Closed

Dropdown in Grid view needs two-time click again #1440

metas-dh opened this issue Dec 12, 2017 · 5 comments
Assignees
@pablosichert @metas-dh
Labels
branch:master branch:release priority:high type:bug

Comments

@metas-dh
Copy link
Member

Is this a bug or feature request?

Bug

What is the current behavior?

If there are >1 values in dropdown list, you need to click two times for selection.

Which are the steps to reproduce?

see #1347: was already fixed there, but is happening again

What is the expected or desired behavior?

Should work the first time.
@pablosichert pablosichert mentioned this issue Dec 15, 2017
Closed
@pablosichert
Copy link
Contributor

This has most likely been reintroduced by #1432

pablosichert added a commit that referenced this issue Dec 15, 2017
@pablosichert
Only consider onBlur event when component was entered by handleClick
c914284 
Otherwise, onBlur fires and unmounts dropdown items before handleSelect can be triggered.

Issue #1347 and #1440
@pablosichert pablosichert mentioned this issue Dec 15, 2017
Merged
@pablosichert
Copy link
Contributor

Note to IT:

@metas-mk
Copy link
Member

@pablosichert quick test. the fix breaks #1421 again
image

@teosarca teosarca mentioned this issue Dec 15, 2017
Merged
pablosichert added a commit that referenced this issue Dec 22, 2017
@pablosichert
Only consider onBlur event when component was entered by handleClick
0365937 
Otherwise, onBlur fires and unmounts dropdown items before handleSelect can be triggered.

Issue #1347 and #1440
pablosichert added a commit that referenced this issue Dec 22, 2017
@pablosichert
Dirty fix: Do not ignore blur event when focus was initiated by the t…
355cd21 
…ab key

Issue #1440, Issue #1421
@pablosichert pablosichert mentioned this issue Dec 22, 2017
Merged
pablosichert added a commit that referenced this issue Dec 22, 2017
@pablosichert
Revert "Revert "Fix dropdown in grid needing two clicks to activate""
bb5ee10 
Issue #1440
pablosichert added a commit that referenced this issue Dec 22, 2017
@pablosichert
Allow dropdown to close after confirming a selection
0cb628f 
Issue #1440
@pablosichert pablosichert mentioned this issue Dec 22, 2017
Merged
metas-mk added a commit to metasfresh/metasfresh that referenced this issue Dec 22, 2017
@metas-mk
Update ReleaseNotes.md
8f38bd8 
Adding new issue to release notes
metasfresh/metasfresh-webui-frontend-legacy#1440
Dropdown in Grid view needs two-time click again
metas-ts pushed a commit that referenced this issue Dec 22, 2017
@pablosichert @metas-ts
Only consider onBlur event when component was entered by handleClick
f73dce2 
Otherwise, onBlur fires and unmounts dropdown items before handleSelect can be triggered.

Issue #1347 and #1440

(cherry picked from commit 0365937)
metas-ts pushed a commit that referenced this issue Dec 22, 2017
@pablosichert @metas-ts
Dirty fix: Do not ignore blur event when focus was initiated by the t…
1ae5f08 
…ab key

Issue #1440, Issue #1421

(cherry picked from commit 355cd21)
metas-ts pushed a commit that referenced this issue Dec 22, 2017
@pablosichert @metas-ts
Allow dropdown to close after confirming a selection
f0c183f 
Issue #1440

(cherry picked from commit 0cb628f)
@metas-dh metas-dh self-assigned this Jan 8, 2018
@metas-dh
Copy link
Member Author

metas-dh commented Jan 8, 2018

Results of IT1
tested in last weekly release e2e

  • Dropdown in Grid view: selection works the first time: OK
  • Dropdown lists do not remain displayed after losing focus: OK

@metas-dh
Copy link
Member Author

metas-dh commented Jan 9, 2018

Update: also worked fine in this week's e2e.

@metas-dh metas-dh closed this as completed Jan 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pablosichert pablosichert

@metas-dh metas-dh

Labels
branch:master branch:release priority:high type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@teosarca @metas-ts @pablosichert @metas-mk @metas-dh