Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Extend notifications functionality #288

Closed
cadavre opened this issue Feb 14, 2017 · 7 comments
Closed

Extend notifications functionality #288

cadavre opened this issue Feb 14, 2017 · 7 comments

Comments

@cadavre
Copy link
Contributor

cadavre commented Feb 14, 2017

Is this a bug or feature request?

Feature request

What is the current behavior?

Notifications appear and disappear not taking into consideration user actions.

Which are the steps to reproduce?

Generate any UI error.

What is the expected or desired behavior?

  1. If mouse hovers notification – it shall not disappear until mouse is out.
  2. Add running "progress bar" which will indicate how long notification will be displayed.
  3. Stack similar errors into one notification. Thinking about adding "number pile" somewhere to indicate amount (as example look JS console).
  4. Close API error into user-friendly (but lacking of info) short simple text reflecting HTTP errors. Show "Server error" (5xx), "User input error" (400), "Client error" (4xx) instead of full error texts.
  5. Instead of full error text in notification add system flag (like "dev=true") which will enable error notification click to open modal popup with error details.
@cadavre cadavre added this to the 2017-08 milestone Feb 14, 2017
@cadavre
Copy link
Contributor Author

cadavre commented Feb 14, 2017

Benchmark: http://codeseven.github.io/toastr/demo.html (enable "Progress" and play with mouse hover) – this is what we want.

@teosarca
Copy link
Member

wow, very very nice!

about 4. and 5., i think backend shall provide this ( task #253 ). Until that, i think there is nothing u can do about it.

@cadavre
Copy link
Contributor Author

cadavre commented Feb 14, 2017

@teosarca actually we can – we will simply always display this short texts in notifications. We very rarely have human-readable texts in errors and even if we understand "404something" or "field BPartner_ID is not NULL" – user doesn't have to. That's why I think this click on notification may help someone who actually would want to understand the error. Wdyt?

@metas-mk
Copy link
Member

@cadavre Nice Idea, but let's discuss things like this later when we have time for such details. many to do before this ;-)

@cadavre
Copy link
Contributor Author

cadavre commented Feb 15, 2017

@metas-mk disagree. It's a part of getting into #253 . We're lack of errors in many, many places so what we do right now is talk a lot about "what should happen" between frontend-API communication. Poor part is that we don't have user-friendly messages for users and we (devs) don't get errors that are saying what shall happen while calling API. In short: there are no validators at all. What I'm trying to do is actually push you more into taking this issue into consideration, because as for me: it is "High priority" issue.

@damianprzygodzki damianprzygodzki self-assigned this Feb 17, 2017
damianprzygodzki added a commit that referenced this issue Feb 17, 2017
@metas-mk metas-mk modified the milestones: 2017-09, 2017-08 Feb 28, 2017
damianprzygodzki added a commit that referenced this issue Feb 28, 2017
damianprzygodzki added a commit that referenced this issue Mar 1, 2017
damianprzygodzki added a commit that referenced this issue Mar 1, 2017
damianprzygodzki added a commit that referenced this issue Mar 1, 2017
@metas-mk metas-mk modified the milestones: 2017-10, 2017-09, 2017-11 Mar 6, 2017
@metas-mk metas-mk modified the milestones: 2017-12, 2017-11 Mar 22, 2017
@metas-lc metas-lc self-assigned this Mar 29, 2017
@metas-lc
Copy link

  • If mouse hovers notification – it shall not disappear until mouse is out NOK
  • Add running "progress bar" which will indicate how long notification will be displayed. NOK
    (if i do an order and add an invalid bpartner it's OK (mouse hover and progress bar))
  • Close API error into user-friendly (but lacking of info) short simple text reflecting HTTP errors. Show "Server error" (5xx), "User input error" (400), "Client error" (4xx) instead of full error texts. OK
  • if you select show more you can see details about your error OK

about NOK:

@metas-mk metas-mk modified the milestones: 2017-15, 2017-12 Apr 5, 2017
@metas-lc
Copy link

metas-lc commented Apr 6, 2017

IT2
retested IT1 and all went fine
OK

@metas-lc metas-lc closed this as completed Apr 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants