Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Leave Location editor with no entry #294

Closed
metas-mk opened this issue Feb 14, 2017 · 8 comments
Closed

Leave Location editor with no entry #294

metas-mk opened this issue Feb 14, 2017 · 8 comments

Comments

@metas-mk
Copy link
Member

Is this a bug or feature request?

Bug.

What is the current behavior?

One cannot leave the Location editor without entering data and leaving the Location untouched.

Which are the steps to reproduce?

Press on Location "Edit" Button. Press next to Dropdown to collapse it or press . Error pops up.

What is the expected or desired behavior?

Be able to leave the Editor without entering data.
image

@metas-mk metas-mk added this to the 2017-08 milestone Feb 14, 2017
@bambeusz bambeusz self-assigned this Feb 15, 2017
bambeusz pushed a commit that referenced this issue Feb 15, 2017
damianprzygodzki added a commit that referenced this issue Feb 15, 2017
fix #294 - closing attributes dropdown without providing data possible
@metas-mk metas-mk self-assigned this Feb 15, 2017
@metas-dh metas-dh self-assigned this Feb 15, 2017
@metas-dh
Copy link
Member

Results of IT1
tested on w101 & cloudit:

  • Press Edit button in Location, press Edit button again or Done to leave Location editor: Error pops up, NOK

@metas-dh metas-dh reopened this Feb 15, 2017
@bambeusz
Copy link
Contributor

bambeusz commented Feb 16, 2017

@metas-dh, I cannot reproduce this error. Could you please provide particular view (window, document)?

@damianprzygodzki
Copy link
Contributor

@chmieludaniel check issue from reference. Window 540196, document 1000003, field M_AttributeSetInstance_ID.

It is problem with:

Uncaught TypeError: Reduce of empty array with no initial value
    at Array.reduce (native)

Attributes.js:125

damianprzygodzki added a commit that referenced this issue Feb 17, 2017
fix #294 - fields in attributes are validated only when there are mandatory inside
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Feb 18, 2017
[#227](metasfresh/metasfresh-webui-frontend-legacy#277) Processed HU in Material Receipt Workflow
[#137](metasfresh/metasfresh-webui-api-legacy#137) Make sure ProcessInstance is not override by concurrent REST api call
[#294](metasfresh/metasfresh-webui-frontend-legacy#294) Leave Location editor with no entry
@metas-mk
Copy link
Member Author

Tested. Is now possible to leave the location editor w/o editing anything and pressing or clicking mouse outside the location editor or pressing editor button. BUT ...
... once you've clicked inside the location editor you don't get out anymore w/ mouse click, outside the editor, nor the button. You have to focus in a field and then cam press to get out again.
--> Not solved. reopening.

@teosarca
Copy link
Member

@chmieludaniel why the "integrated" label was removed?

NOTE: the "integrated" label shall be sticky. once integrated, nobody shall take it out.

@bambeusz
Copy link
Contributor

bambeusz commented Feb 28, 2017

Correct me if I'm wrong:

The 1st solution was integrated, but then other bug was found, so the issue was reopened. Hnce, the bug is not solved - not integrated.

In case we leave label and don't close issues, is there way to see, that this issue is still todo? (other than reading whole comment history)

@teosarca
Copy link
Member

if that's the case, and there were reasons to postpone the TODO part,
i think it's better to create a follow-up task and close this one mentioning what was delivered here.
wdyt?

but, nevertheless, pls don't remove the "integrated" label because that's the only way for us to check if a task was "partially" integrated.

@metas-mk
Copy link
Member Author

metas-mk commented Mar 14, 2017

Tested. Works nicely now, like required. Closing.
Tested w/ diverse entries in Business Partner Window and Quick entry via Sales Order.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants