Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Show password option for Password widget #863

Closed
teosarca opened this issue Jun 10, 2017 · 7 comments
Closed

Show password option for Password widget #863

teosarca opened this issue Jun 10, 2017 · 7 comments

Comments

@teosarca
Copy link
Member

Type of issue

Feature request

Current behavior

The password widgets are rendered as password input fields and there is no way to see the password even if you want and even if in some cases this is OK.

Expected behavior

In case of Password widget types, along with the "widgetType" the API shall also provide the "allowShowPassword" flag.
Alternatively we could introduce another widgetType, e.g. PasswordDisplayable for this case. Not sure if it's better, wdyt?

If that flag is set, the frontend shall show a nice button or icon (with an eye?) to allow the user seeing the password.
How the button/icon shall look like and behave shall be proposed by the UX/designer.

image

@cadavre
Copy link
Contributor

cadavre commented Jun 12, 2017

+1 for the button which will display the password when mouse is over, click button is presses and HOLD. On click button release password shall be hidden again. (So no toggle button, but press-and-hold to show.)

@damianprzygodzki
Copy link
Contributor

In case of Password widget types, along with the "widgetType" the API shall also provide the "allowShowPassword" flag.

Definitely we should attach flag in widget layout.

@teosarca
Copy link
Member Author

NOTE: atm the widgetType is provided in data and not in layout.
I hope it's OK if we will provide the "allowShowPassword" in layout.

@damianprzygodzki
Copy link
Contributor

damianprzygodzki commented Jun 12, 2017

NOTE: atm the widgetType is provided in data and not in layout.
I hope it's OK if we will provide the "allowShowPassword" in layout.

If API won't be changing it during widget lifecycle, then ok.

@teosarca
Copy link
Member Author

nop, it won't change it.

damianprzygodzki added a commit that referenced this issue Jun 12, 2017
damianprzygodzki added a commit that referenced this issue Jun 12, 2017
@teosarca
Copy link
Member Author

Update: quick tested this on localhost but it seems the "show password" button is not displayed

image

damianprzygodzki added a commit that referenced this issue Jun 13, 2017
@metas-mk metas-mk self-assigned this Jun 13, 2017
metas-mk added a commit to metasfresh/metasfresh that referenced this issue Jun 13, 2017
Adding this new Issue to the upcoming release:
metasfresh/metasfresh-webui-frontend-legacy#863 Show password option for Password widget
@metas-mk
Copy link
Member

Tested. Works as required/ needed for this iteration. Closing/ Done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants