Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Add frontend support for modifying the KPI config (caption, offset, etc) #977

Closed
metas-rc opened this issue Jul 4, 2017 · 4 comments
Closed

Comments

@metas-rc
Copy link
Member

metas-rc commented Jul 4, 2017

Type of issue

Feature request

Current behavior

Currently, if a user wants to modify the caption(name) or offset of a KPI, they have to go to "Elastic Search KPI" and change in the table.

Expected behavior

The caption, offset , etc shall be editable in the KPI widget itself.

Steps to reproduce

Try and see

Note: Talked with Teo and this is supported by the backend.

@metas-rc metas-rc added this to the Backlog milestone Jul 4, 2017
@cadavre cadavre modified the milestones: Backlog, 2017-31 Jul 25, 2017
@cadavre
Copy link
Contributor

cadavre commented Jul 25, 2017

Waiting for more docs from @teosarca about how to use API.

@teosarca
Copy link
Member

Those 2 API endpoints (which work basically in the same way, just that one is about KPIs while the other is about Target Indicators) accepts the standard PATCH format, i.e.

[
  {
    "op": "replace",
    "path": "caption",
    "value": {}
  }
]

The op (operation) shall be "replace".

The "path" and "value" can be:

  1. "path":"caption" => the value shall be the new caption
  2. "path":"interval" => the value can be "week" (yes, there is one value supported atm)
  3. "path":"when" => the value can be "now", "lastWeek"

NOTE: in future we will support more values, we might even introduce an endpoint for fetching available values but for now we stick with what we have :)

@teosarca teosarca assigned teosarca and unassigned teosarca Jul 25, 2017
@Dunkat Dunkat self-assigned this Jul 25, 2017
Dunkat added a commit that referenced this issue Jul 27, 2017
cadavre added a commit that referenced this issue Aug 1, 2017
Add frontend support for modifying the KPI config (caption, offset, etc) #977
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Aug 4, 2017
[#1111](metasfresh/metasfresh-webui-frontend-legacy#1111)
Lookup Selection Lists not shown in Sequence anymore
[#1098](metasfresh/metasfresh-webui-frontend-legacy#1098)
Cant select last entry in dropdown list
[#2107](#2107) Error:
Missing ESR creditor reference on CAMT 54 Import
[#2106](#2106)
NullPointerException on CAMT 54 Import
[#1089](metasfresh/metasfresh-webui-frontend-legacy#1089)
Avatar Tooltip opens and stays open after selecting Avatar Settings
[#1095](metasfresh/metasfresh-webui-frontend-legacy#1095)
Sales Order Batch Entry with Key Shortcut not working
[#1051](metasfresh/metasfresh-webui-frontend-legacy#1051)
Cut-Off Header names
[#1077](metasfresh/metasfresh-webui-frontend-legacy#1077)
Sitemap Navigation [arrow-up] not working
[#1063](metasfresh/metasfresh-webui-frontend-legacy#1063)
view: when refreshing the page the data is loaded twice
[#1048](metasfresh/metasfresh-webui-frontend-legacy#1048)
POST .../documentView/{windowId} is called twice when opening a view
[#977](metasfresh/metasfresh-webui-frontend-legacy#977)
Add frontend support for modifying the KPI config (caption, offset, etc)
[#2101](#2101) webui -
allow disabling auto-close of picking candidates
[#1771](#1771) add legacy
features

me-45
@metas-lc
Copy link

metas-lc commented Aug 10, 2017

IT

  1. dashboard -> actions menu -> open edit mode
    => each kpi has a gear and if you select it you can change: caption , interval and when

  2. set them all
    => noticed that the numbers and name change OK
    => question: i notice that once you set interval or when , you can't set them back to null. Wanted?
    => question: notice that the KPI you updated changes it's place. Is that wanted?

  3. get back in gear
    => name is as you last set it
    => interval and when are empty. OK? Wanted? if you press ok it won't return to initial value..

created follow-up: #1273

@metas-mk metas-mk modified the milestones: 2017-31, 2017-40 Oct 4, 2017
@metas-lc metas-lc self-assigned this Oct 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants