Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

New Widget for Date Range #981

Closed
metas-mk opened this issue Jul 5, 2017 · 11 comments
Closed

New Widget for Date Range #981

metas-mk opened this issue Jul 5, 2017 · 11 comments

Comments

@metas-mk
Copy link
Member

metas-mk commented Jul 5, 2017

Type of issue

Feature request

Current behavior

Currently, there is no Widget for Date-Range in WebUI

Expected behavior

Have a Date Range Widget, similar to what we already have in Filter Widget.

@wiadev
Copy link
Contributor

wiadev commented Jul 11, 2017

How values of this widget should be persisted in database?

We have single value for each property updated using PATCH request.
My question how to represent date range if we need to store two values (start and end dates).

This could be array of dates, e.g. [start, end]
Or JSON serialized representation, like {"start": 1234, "end": 2345}

Please let me know how to store those values.

@cadavre
Copy link
Contributor

cadavre commented Jul 11, 2017

Take a look at datetimerange widget used in filters. I guess it would be nice to keep same data structure.

@metas-mk
Copy link
Member Author

metas-mk commented Jul 12, 2017

@wiadev you can find an example to see the date-range wiget in action in window/143
press on the first filter "date ordered"
the endpoints for the usage in process parms will be provided by @teosarca in the issue 491 mentioned above.
image

@teosarca
Copy link
Member

hi guys,

I think we cannot use the JSON format that we are using for filtering because there we have something like this:
image

In case of date range process parameter we can agree to something similar to "filters" and also to what @wiadev proposed, i.e.

{ "value":"...", "valueTo":"..." }

note: "parameterName" is not needed.

wdyt?

@teosarca
Copy link
Member

and more, in future we will need support for other "range" types like

  • string range
  • integer/amount/quantity etc

For those cases i would suggest to use the same format (i.e. {"value":"..", "valueTo":".."} ).

But that's for the future.
I am writing it here to have an overview about where we are heading too.

@teosarca
Copy link
Member

Moving it to backlog, until the API is ready.
But nevertheless, pls feel free to comment and give more input or suggestions.

@teosarca teosarca modified the milestones: Backlog, 2017-29 Jul 12, 2017
@wiadev wiadev removed their assignment Jul 28, 2017
@wiadev
Copy link
Contributor

wiadev commented Sep 7, 2017

@teosarca backend api is ready for this issue?

@teosarca
Copy link
Member

teosarca commented Sep 7, 2017

@wiadev not yet

@teosarca
Copy link
Member

@wiadev ready to be developed, see metasfresh/metasfresh-webui-api-legacy#491 (comment)

@teosarca
Copy link
Member

for testing you can use https://w101.metasfresh.com:8443/window/540112/1000001
image

@metas-dh
Copy link
Member

Results of IT1
tested in mf15

  • date range widget, e.g. in window 540112: OK
  • date range is set as selected, e.g. today, this month, or custom range: OK

metas-ts added a commit to metasfresh/metasfresh that referenced this issue Oct 27, 2017
[#2546](#2546) Mark all Value and DocumentNo columns as IsCalculated=Y
[#2684](#2684) Material Dispo - map planning records with actual M_Transactions
[#2751](#2751) Add flatrate term relations from order and partner to new window contract
[#2800](#2800) Make de.metas.document.archive.process.ExportArchivePDF work in webui
[#2847](#2847) Elasticsearch shall use slf4j instead of log4j
[#644](metasfresh/metasfresh-webui-api-legacy#644) Hide window actions which are not available
[#645](metasfresh/metasfresh-webui-api-legacy#645) window/actions: introduce support for selectedTabId and selectedRowIds
[#981](metasfresh/metasfresh-webui-frontend-legacy#981) New Widget for Date Range
[#1296](metasfresh/metasfresh-webui-frontend-legacy#1296) Add storybook for isolated visual component testing
[#41](metasfresh/metasfresh-dist-orgs#41) Add medium invoice report
[#55](metasfresh/metasfresh-dist-orgs#55) Refactor Migration Scripts for dist orgs
[#72](metasfresh/metasfresh-dist-orgs#72) Invoice Medium ESR and other Adjustments
[#2634](#2634) Make the CalloutBankStatement webui compliant
[#2719](#2357) exception when using process quotation to sales order with parameter complete order
[#2818](#2818) Flatrate: Have relation from Sales Order to invoice candidate
[#2823](#2823) Add C_Invoice_Candidate.Priority missing column
[#2836](#2836) Setup wizard shall not inactivate ESR
[#643](metasfresh/metasfresh-webui-api-legacy#643) Picking Tray Clearing requery to see the right view
[#647](metasfresh/metasfresh-webui-api-legacy#647) shipped HU is still visible in picking terminal
[#67](metasfresh/metasfresh-dist-orgs#67) Fix Jasper Version of Invoice Medium
[#80](metasfresh/metasfresh-dist-orgs#80) Invoice Medium Preview working in Jasper but not on server

me-45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants