This repository has been archived by the owner on Dec 13, 2020. It is now read-only.
Fix calendar icon to fit properly after field #1428 #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- open calendar by default after double-click
metas-mk
reviewed
Jan 12, 2018
src/components/widget/DatePicker.js
Outdated
| <Datetime | ||
| closeOnTab={true} | ||
| renderDay={this.renderDay} | ||
| renderInput={this.renderInput} | ||
| onBlur={this.handleBlur} | ||
| onFocus={this.handleFocus} | ||
| {...this.props} | ||
| open={true} |
There was a problem hiding this comment.
@wiadev seems as if the datepickers are now always initially opened and don't close anymore.
see the following example
metas-mk
reviewed
Jan 12, 2018
src/components/widget/DatePicker.js
Outdated
| <Datetime | ||
| closeOnTab={true} | ||
| renderDay={this.renderDay} | ||
| renderInput={this.renderInput} | ||
| onBlur={this.handleBlur} | ||
| onFocus={this.handleFocus} | ||
| {...this.props} | ||
| open={true} |
There was a problem hiding this comment.
Also in edit mode. After doubleclick on the datefield to switch into edit more, the datepicker does not dissappear after selection anymore.
metas-mk
reviewed
Jan 12, 2018
|
@metas-mk updated |
- Remove z-index: -1 from meta-date-picker icon
|
please, check #1507, first before this PR. |
|
Quick local check OK. Integrating. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1428