Wait with closing the modal until all PATCH requests are finished #1500
Conversation
@pablosichert hmm... but that means, in case any of PATCH requests fails, user will never be able to close the window. right? |
No, not quite. Just his current attempt will be aborted (by leaving the modal open). If he clicks the done button right after again, he will be able to close it. |
|
My question is rather: Is it too subtle for the user to notice that something went wrong if we just leave the modal open? Should we give a more explicit hint? |
Not sure I am picturing it correctly, but in case the user presses Done and the window is not closing because of some endpoint call which failed, IMHO, we shall display that error because else user will not understand what happened. wdyt? |
👍 I think the default error notification at the top right will appear when one of the requests errors, but can't confirm currently. |
Just checked - It just fails silently. Will add the error notification |
|
Checked again - I didn't get an error notification because of the way I mocked out a failed request. There's no special case here, so we should get the error notification when a @teosarca I can add an extra error notification informing the user why the modal could not close, wdyt? |
|
Checked locally. The issue solved. Integrating. |
|
@pablosichert let's see how it turns in testing... cannot make up my mind |
Regarding what? 😄 If this thing is resilient? |
|
about this:
|
#1361
@teosarca: What should happen if one of the requests failed? Currently I just prevent the modal from closing and do nothing after.