This repository has been archived by the owner on Dec 13, 2020. It is now read-only.
Improve the test environment #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siemiatj
force-pushed
the
dev-test-environment
branch
3 times, most recently
from
5eb87bd to
2162ffa
Compare
|
hi @siemiatj i would like to help making them execute on jenkins. yarn install
yarn lint --quiet
yarn test
webpack --config webpack.prod.js --bail --display-error-detailsin the Jenkinsfile... |
|
@metas-ts It'll run on Jenkins in the same way as it did before. We just need more tests that actually test something. What we had right now was barely testing anything so they'd never crash :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided to use facebook's Jest for our testing environment, as it's really easy to work with, and gives a lot of built-in options (like test coverage we can turn on later) and flexibility. Rewritten current tests as well so everything should work in Jenkins too.
#1501