This repository has been archived by the owner on Dec 13, 2020. It is now read-only.
fix #215 - added shortcut for change doc status to complete #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damianprzygodzki
suggested changes
Feb 15, 2017
| import React, { Component } from 'react'; | ||
| import { Shortcuts } from 'react-shortcuts'; | ||
|
|
||
| class PaginationContextShortcuts extends Component { |
There was a problem hiding this comment.
@chmieludaniel wrong class name.
| } | ||
|
|
||
| handleChangeStatus = (status) => { | ||
| this.props.onChange(status); |
There was a problem hiding this comment.
If you are changing some file and it is out of our code schema, please fix it too beside.
const {onChange} = ...
There was a problem hiding this comment.
and whats more, here i believe you can use const instead of let
| @@ -132,8 +146,13 @@ class ActionButton extends Component { | |||
| <div className={"tag tag-" + this.getStatusContext(abrev)}>{value} </div> | |||
| <i className={"meta-icon-chevron-1 meta-icon-" + this.getStatusContext(abrev)} /> | |||
| <ul className="dropdown-status-list"> | |||
| {this.renderStatusList(this.state.list)} | |||
There was a problem hiding this comment.
Great, thats what im asking, thank you.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.