Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Lookup revamp – collective issue #600 #782

Merged
merged 30 commits into from
May 29, 2017
Merged

Lookup revamp – collective issue #600 #782

merged 30 commits into from
May 29, 2017

Conversation

Dunkat
Copy link
Contributor

@Dunkat Dunkat commented May 23, 2017

No description provided.

@Dunkat Dunkat requested a review from damianprzygodzki May 23, 2017 11:36
Copy link
Contributor

@damianprzygodzki damianprzygodzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • cache should be enabled for each field of lookup
  • when changing parent field the children (without default value) before set are preserved from previous value
  • when value for child (i.e. 'AD_USER_ID') is set from API, the field is not updated

Copy link
Contributor

@damianprzygodzki damianprzygodzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • when you are removing first value (lookup is red)
    and then you are typing something, and then use arrow-down, the selected text is not visible
  • in table cell lookup ( x ) icon is moved
  • after change-yellow-fadein-out the red colour is fading as well
  • lookup as a filter is totally not clickable

@damianprzygodzki damianprzygodzki merged commit 49f2fba into master May 29, 2017
@damianprzygodzki damianprzygodzki deleted the dev-600 branch May 29, 2017 11:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants