New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean C_PaySelection #3137

Closed
metas-rc opened this Issue Dec 5, 2017 · 2 comments

Comments

Projects
None yet
4 participants
@metas-rc
Member

metas-rc commented Dec 5, 2017

Is this a bug or feature request?

  • FR

What is the current behavior?

  • The C_PaySelection was changed into a document. Remove all that is no longer needed.

Which are the steps to reproduce?

What is the expected or desired behavior?

DONE ( by Tobi):

  • rename process to C_PaySelection_SEPA_XmlExport (follow best-practice of having the process value and class start with the table in question)
  • assign process to the gear and only show it if the C_PaySelection record is competed/closed
  • when exporting to XML, don't filter by C_PayselectionLine.Processed='Y'
  • when exporting to XML, use Strd for payment type 1 (ESR) and Ustrd for payment type 3 (iban)

TODO:

  • remove processed column from C_PaySelectionLine
  • remove sepa-export and processing fields and columns
  • remove C_PaySelection_ReActivate process

@metas-rc metas-rc self-assigned this Dec 5, 2017

metas-rc added a commit that referenced this issue Dec 5, 2017

metas-rc added a commit that referenced this issue Dec 6, 2017

metas-rc added a commit that referenced this issue Dec 6, 2017

metas-ts added a commit that referenced this issue Dec 10, 2017

Update ReleaseNotpes.md
[#727](metasfresh/metasfresh-webui-api#727)
Allow search of Subproducer
[#3079](#3079) Warehouse
picking group
[#1421](metasfresh/metasfresh-webui-frontend#1421)
Drop down lists remain displayed when using tab several times
[#3150](#3150) Always
keep Terms & Conditions equal per Compensation Group
[#714](metasfresh/metasfresh-webui-api#714)
login authenticate: provide an unique key for each JSONLoginRole
[#1404](metasfresh/metasfresh-webui-frontend#1404)
login form selects 2 items from roles dropdown
[#3174](#3174) Material
Receipt Candidates not generates when using Purchase Order from Sales
Order action
[#1406](metasfresh/metasfresh-webui-frontend#1406)
Can not enter "-" into any text field
[#721](metasfresh/metasfresh-webui-api#721)
picking terminal: HUs to pick: scan/filter by Locator
[#722](metasfresh/metasfresh-webui-api#722)
picking terminal: picking slot rows shall NOT have duplicate IDs
[#3139](#3139) Cannot
edit System Administrator role (AD_Role_ID=0)
[#1396](metasfresh/metasfresh-webui-frontend#1396)
View field editor: Patch request isn't sent after hit enter
[#3171](#3171) Add view
to keep track of unprocessed async work packages
[#3149](#3149) Automatic
Discount for Group Products
[#1414](metasfresh/metasfresh-webui-frontend#1414)
view: don't allow user to sort by a given column if layout says so
[#1425](metasfresh/metasfresh-webui-frontend#1425)
eslint: increase line max-len from 80 to 120.
[#716](metasfresh/metasfresh-webui-api#716)
picking terminal: scan picking slot by barcode
[#723](metasfresh/metasfresh-webui-api#723)
picking terminal: HUs to pick: Pick CUs process
[#3137](#3137) Clean
C_PaySelection
[#3160](#3160)
C_Printing_Queue_ReEnqueue with IsSelected doesn't work
[#713](metasfresh/metasfresh-webui-api#713)
Error creating bean with name 'scopedTarget.internalUserSessionData'
[#1383](metasfresh/metasfresh-webui-frontend#1383)
cannot completely delete a numeric field in grid view
[#3138](#3138) Import
BPartner window: cannot see data
[#2340](#2340) Relation
Type: changelog
[#3151](#3151)
ZoomTo-Performance Issues
[#3147](#3147) Errors wrt
C_BPartner SQL columns
[#2338](#2338) Relation
Type: fact_accounts
[#3110](#3110) Request
All does not show records
[#1407](metasfresh/metasfresh-webui-frontend#1407)
process result: open included view: handle profileId property
[#3105](#3105) Improve
Product import process
[#711](metasfresh/metasfresh-webui-api#711)
picking terminal: additional shall support grouping lines by order
[#3058](#3058)
TableRecordId relation types to support Prefix_AD_Table_ID and
Prefix_Record_ID
[#3126](#3126) Solve
issues around standalone report / jasper service
[#1393](metasfresh/metasfresh-webui-frontend#1393)
View attributes: consider row's supportAttributes property before
querying for attributes
[#1361](metasfresh/metasfresh-webui-frontend#1361)
View field editor: make sure the field value is sent to backend before
the view is deleted

@metas-lc metas-lc self-assigned this Dec 18, 2017

@metas-lc

This comment has been minimized.

Show comment
Hide comment
@metas-lc

metas-lc Dec 19, 2017

Contributor

IT

  • made a new C_PaySelection manually (window payment selection, id 206) => there is no action to "Create from" NOK
  • added a new line, with an invoice, manually => the reference was not set (probably i had some config missing?) OK??? - probably is added if you create the lines with "Create from"
  • i added a reference and completed the payment selection => i didn't find any SEPA action NOK
Contributor

metas-lc commented Dec 19, 2017

IT

  • made a new C_PaySelection manually (window payment selection, id 206) => there is no action to "Create from" NOK
  • added a new line, with an invoice, manually => the reference was not set (probably i had some config missing?) OK??? - probably is added if you create the lines with "Create from"
  • i added a reference and completed the payment selection => i didn't find any SEPA action NOK

metas-mk added a commit that referenced this issue Apr 28, 2018

metas-mk added a commit that referenced this issue Apr 28, 2018

@metas-mk metas-mk removed their assignment Apr 28, 2018

@metas-lc metas-lc self-assigned this May 2, 2018

@metas-lc

This comment has been minimized.

Show comment
Hide comment
@metas-lc

metas-lc May 3, 2018

Contributor

IT
0. make sure you have some invoices with a bpartner that has bank account andinvoices should have po references

  1. made a new C_PaySelection manually (window payment selection, id 206)
    => there is action to "Create from" OK
    (it has Business Partner Group, Business Partner, Match Requirement, Zahldatum, Only Due, Only Discount, Include Disputed)
  2. set params (i choose to have all checkboxes on N and Match Requirement on All)
    => new lines were added OK
    (in reference field was set the reference from invoice)
  3. complete the pay selection, go to actions
    => sepa export action is there OK
    (there is no button to choose where to save the file. See if we need a task for that metasfresh/metasfresh-webui-frontend#1778)
Contributor

metas-lc commented May 3, 2018

IT
0. make sure you have some invoices with a bpartner that has bank account andinvoices should have po references

  1. made a new C_PaySelection manually (window payment selection, id 206)
    => there is action to "Create from" OK
    (it has Business Partner Group, Business Partner, Match Requirement, Zahldatum, Only Due, Only Discount, Include Disputed)
  2. set params (i choose to have all checkboxes on N and Match Requirement on All)
    => new lines were added OK
    (in reference field was set the reference from invoice)
  3. complete the pay selection, go to actions
    => sepa export action is there OK
    (there is no button to choose where to save the file. See if we need a task for that metasfresh/metasfresh-webui-frontend#1778)

@metas-lc metas-lc closed this May 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment