Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-add a rename rule for Hive snapshot #1331

Closed
joohokim1 opened this issue Jan 29, 2019 · 9 comments
Closed

Auto-add a rename rule for Hive snapshot #1331

joohokim1 opened this issue Jan 29, 2019 · 9 comments
Assignees
@paigechoi @sang-hee-lee @joohokim1
Labels
@dataprep Component Name : Data preparation enhancement Request Change and Feature Enhancement
Milestone
3.2.0

Comments

@joohokim1
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Column names containing unicode and space, and so on cannot be accepted in Hive.
Currently, if there are forbidden column names, an error occurs with direction to rename them.

2019-01-29 3 20 29

Describe the solution you'd like
It would be better if we help to append a rename rule.
In stead of sending the request, UI should show multi-column rename pop-up.
We can fill with appropriate names in advance like below.

2019-01-29 3 25 18

Additional context
Hangul unicode letter -> Romanize (https://www.npmjs.com/package/aromanize)
Space -> _
Column names containing other unicode letters -> just column1, column2, etc.
@joohokim1 joohokim1 added enhancement Request Change and Feature Enhancement @dataprep Component Name : Data preparation labels Jan 29, 2019
@joohokim1 joohokim1 added this to the 3.2.0 milestone Jan 29, 2019
@paigechoi paigechoi changed the title Audo-add a rename rule for Hive snapshot Auto-add a rename rule for Hive snapshot Jan 29, 2019
@minjung-cho minjung-cho self-assigned this Mar 12, 2019
@minjung-cho
Copy link

METATRON-1533에서 발췌한 추천 이름 규칙입니다.

  • 한글은 로마자로 변경
  • 한글 이외 유니코드가 하나라도 포함된 컬럼인 경우에는 column1, column2, ...
  • 공백은 _ 로 변경
  • 대문자는 소문자로 변경

@minjung-cho
Copy link

minjung-cho commented Mar 12, 2019 •
edited
Loading

Rename 팝업에 내용 추가하였습니다.
스크린샷 2019-03-12 오후 2 14 04
@joohokim1 @ksparknot
컬러명 자동 추천은 Rename 공통 룰에 해당할까요? 하이브 타입 스냅샷 생성시에만 적용되어야 할까요?
@paigechoi 포커스 컬럼에 따라 그리드가 이동하는 이슈를 묶어도 될듯합니다만.. 혹시 별도 이슈가 있는지요?

@paigechoi
Copy link
Contributor

#1638 scroll이슈입니다

@minjung-cho
Copy link

@koeun222 데이터 그리드의 포커스 부분 디자인은 #1638로 분리 부탁드립니다

@joohokim1
Copy link
Contributor Author

@minjung-cho @ksparknot
컬럼명 자동 추천은 Hive 스냅샷을 만들다가 문제가 되는 경우만 해주면 될 것 같습니다.
Hive snapshot 생성을 요청하면 "Hive에 저장되기에 적합하지 않은 컬럼명이 있습니다. 전체 rename 창을 띄울까요?" 정도 dialog 창이 뜨면 좋겠습니다. 여기서 Yes인 경우에 한해서 컬럼명 자동 추천을 하면 좋겠습니다.

@minjung-cho minjung-cho added the awaiting feedback need to feedback label Mar 13, 2019
@joohokim1 joohokim1 removed the awaiting feedback need to feedback label Mar 13, 2019
@minjung-cho
Copy link

minjung-cho commented Mar 13, 2019 •
edited
Loading

@joohokim1 @AnnieHwang 네, 이해했습니다. 의견 주신 부분 반영한 기획서 입니다. 이해가 다른 부분이 없는지 한번 더 검토 부탁드립니다-
스크린샷 2019-03-13 오후 4 25 13
스크린샷 2019-03-13 오후 4 24 51

@minjung-cho minjung-cho added the awaiting feedback need to feedback label Mar 13, 2019
@joohokim1
Copy link
Contributor Author

@minjung-cho @AnnieHwang @ksparknot @sang-hee-lee @paigechoi

  1. 예 / 아니오 다이얼로그 추가
  2. 기존 multi-column rename 화면/코드 활용
  3. 단 Hive에 적합한 컬럼명 선기입 (확인X 제약X)

전 위처럼 간단하게 처리하고 넘어가려고 했거든요. 그래서 본 SP에 할 수 있을 것으로 생각했는데, 제안하신 것처럼 새 화면이나 제약 조건 등이 들어가야한다면, 시간이 별로 없을 것 같습니다.

제가 지금까지 받은 VoC로는 위의 간단한 처리로도 괜찮은 것 같은데, 이번 마일스톤에 빨리 태우고, 다음에 더 개선하는 것은 어떨런지요?

@minjung-cho
Copy link

@joohokim1 @sang-hee-lee @paigechoi 네, 제가 보기엔 기존 화면을 활용하는 선인것 같은데 그게 아닌가 보네요 ㅎ 어떻게 끊을지 결정해서 알려주시면 참고하고 있겠습니다-

@joohokim1
Copy link
Contributor Author

@minjung-cho @AnnieHwang @ksparknot @sang-hee-lee @paigechoi

유선으로 대화 나눈 것처럼, 이번 SP에는 간단히 진행해서, 마일스톤내에 태우기로 하고, 다음 번에 더 UX를 보완하기로 했습니다.

@joohokim1 joohokim1 removed the awaiting feedback need to feedback label Mar 14, 2019
@paigechoi paigechoi self-assigned this Mar 14, 2019
paigechoi added a commit that referenced this issue Mar 15, 2019
@paigechoi
#1331 rename columns when columns are inappropriate for hive snapshot
73f5a2e 
- add confirmation popup
- add aromanize(package) to convert korean into english
joohokim1 added a commit that referenced this issue Mar 20, 2019
@joohokim1
#1331 remove first character check for Hive tables
009623b
paigechoi added a commit that referenced this issue Mar 21, 2019
@paigechoi
#1331 Fix validation for renaming
da416e8
paigechoi added a commit that referenced this issue Mar 21, 2019
@paigechoi
#1331 Merge with master
d746d87
paigechoi added a commit that referenced this issue Mar 21, 2019
@paigechoi
#1331 Fix regular expression when renaming column names for hive
ea108fd
@paigechoi paigechoi mentioned this issue Mar 21, 2019
Merged
9 tasks
paigechoi added a commit that referenced this issue Mar 22, 2019
@paigechoi
#1331 Fix regular expression for duplicate column names
0e33d4a
paigechoi added a commit that referenced this issue Mar 22, 2019
@paigechoi
#1331 Fetch dataset grid info when snapshot create popup is opened
1f37d6a 
- do not pass grid data around components (when edit mode, wrong grid data was passed to snapshot create component)
joohokim1 pushed a commit that referenced this issue Mar 22, 2019
@paigechoi @joohokim1
#1331 column rename for hive snapshot
ba676f8 
* #1331 rename columns when columns are inappropriate for hive snapshot
- add confirmation popup
- add aromanize(package) to convert korean into english

* #1331 remove first character check for Hive tables

* #1331 Fix validation for renaming

* #1331 Fix regular expression when renaming column names for hive

* #1331 Fix regular expression for duplicate column names

* #1331 Fetch dataset grid info when snapshot create popup is opened
- do not pass grid data around components (when edit mode, wrong grid data was passed to snapshot create component)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paigechoi paigechoi

@sang-hee-lee sang-hee-lee

@joohokim1 joohokim1

Labels
@dataprep Component Name : Data preparation enhancement Request Change and Feature Enhancement
Projects
None yet
Milestone
3.2.0
Development

No branches or pull requests
4 participants
@minjung-cho @paigechoi @sang-hee-lee @joohokim1