Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation is disabled when a column dictionary of type timestamp is connected. #2242

Closed
ufoscw opened this issue Jun 17, 2019 · 7 comments

Comments

Projects
None yet
5 participants
@ufoscw
Copy link
Contributor

commented Jun 17, 2019

Describe the bug
Validation is disabled when a column dictionary of type timestamp is connected.
Users can not save changes because they can not validate check.

metatron_Discovery

To Reproduce
Steps to reproduce the behavior:

  1. Create timestamp type column dictionary.
  2. Go to Metadata detail screen of DataSource (Engine) type.
  3. Column Schema Tab
  4. apply TimeStamp Column Dictionary.
  5. Save
  6. see error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@ufoscw ufoscw added this to the 3.3.0 milestone Jun 17, 2019

@ufoscw

This comment has been minimized.

Copy link
Contributor Author

commented Jun 17, 2019

@AnnieHwang
In the case of a Timestamp type column dictionary, it is necessary to define in which step the Validation Check will be executed.

  1. After selecting Column Dictionary
  2. Save your edits
@AnnieHwang

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

@ufoscw Please check to the UX Wireframe below :)
image (75)

@ufoscw

This comment has been minimized.

Copy link
Contributor Author

commented Jun 17, 2019

@eltriny
위 기획서 중 Dictionary 추천 정책을 제외한 나머지 부분에 대해 적용 부탁드려요.

@paigechoi

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

image

@AnnieHwang @ufoscw 데이터 소스에서 geo types는 타입을 수정하지 못하도록 정책이 잡혀있습니다.

위에 올려주신 기획서에는 geo types 관련 룰은 정의해주시지 않으셨는데요. 칼럼 딕셔너리를 적용했을 때 geo types도 칼럼 딕셔너리 타입에 맞춰서 수정되는 게 맞는지 확인 부탁 드닙니다.
image

@ufoscw

This comment has been minimized.

Copy link
Contributor Author

commented Jun 25, 2019

@kyungtaak
위 내용 관련해서 Geo Type의 경우 타입 수정이 안되게 기존 로직이 만들어져 있다고 합니다.
컬럼 딕셔너리 적용될 경우 타입이 바뀌는게 기획상으로 맞다고 하는데 이럴 경우 문제가 있나요?

@kyungtaak

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2019

@ufoscw 문제가 있습니다. GeoType의 경우 컬럼 딕셔너리를 설정해도 큰의미가 없어요. 이건 저희가 지도를 쀼려주기 위해 인덱싱한 컬럼이라 메타데이터에서 핸들링하면 안됩니다.

@AnnieHwang

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2019

@paigechoi 그러면 일단 GeoType의 경우 딕셔너리 선택이 불가능하게 처리부탁드려요.

paigechoi added a commit that referenced this issue Jun 26, 2019

#2242 Fix validation error when column dictionary type is timestamp
- Make description editable anytime
- If metadata is datasource type and role is timestamp, do not change format and type
- Refresh logical name, type, code table and description when column dictionary is removed

paigechoi added a commit that referenced this issue Jun 26, 2019

paigechoi added a commit that referenced this issue Jun 27, 2019

ufoscw added a commit that referenced this issue Jun 28, 2019

ufoscw added a commit that referenced this issue Jun 28, 2019

#2242 metadata col dictionary timestamp validation
* #2242 Fix validation error when column dictionary type is timestamp
- Make description editable anytime
- If metadata is datasource type and role is timestamp, do not change format and type
- Refresh logical name, type, code table and description when column dictionary is removed

* #2242 Disable column dictionary click event if column type is geo type

* #2242 Retain timestamp type when removing dictionary (if role is timestamp)

* #2242 apply projection to datasource

@ufoscw ufoscw closed this Jun 28, 2019

ufoscw added a commit that referenced this issue Jul 1, 2019

@ufoscw ufoscw referenced this issue Jul 1, 2019

Merged

#2242 fix proxy casting error with MetadataSource #2287

0 of 7 tasks complete

ufoscw added a commit that referenced this issue Jul 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.