Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make datasets with multiple sheets in excel #748

Closed
paigechoi opened this issue Nov 12, 2018 · 5 comments
Closed

Make datasets with multiple sheets in excel #748

paigechoi opened this issue Nov 12, 2018 · 5 comments
Assignees
Labels
@dataprep Component Name : Data preparation enhancement Request Change and Feature Enhancement
Milestone

Comments

@paigechoi
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When making a dataset with an Excel file, multiple sheets can be used to make Datasets at once.

Describe the solution you'd like
Select multiple sheets when making dataset with excel file -> Selected sheets are made into individual datasets.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@paigechoi paigechoi added enhancement Request Change and Feature Enhancement @dataprep Component Name : Data preparation labels Nov 12, 2018
@paigechoi paigechoi added this to the 3.1.0 milestone Nov 12, 2018
paigechoi added a commit that referenced this issue Nov 15, 2018
kaypark-skt pushed a commit that referenced this issue Nov 15, 2018
paigechoi added a commit that referenced this issue Nov 15, 2018
paigechoi added a commit that referenced this issue Nov 16, 2018
paigechoi added a commit that referenced this issue Nov 16, 2018
@paigechoi
Copy link
Contributor Author

시트 하나로 데이터셋 생성 -> success
시트 여러개로 데이터셋 생성 -> fail (시트 하나로 데이터셋 생성시 사용했던 시트도 multi 에서는 fail)

@joohokim1 joohokim1 modified the milestones: 3.1.0, 3.2.0 Nov 23, 2018
@paigechoi paigechoi removed this from the 3.2.0 milestone Dec 14, 2018
@paigechoi
Copy link
Contributor Author

Closing this issue since requirements have changed.
I'll reopen(or make a new issue) when requirements are all set.

@joohokim1 joohokim1 reopened this Jan 31, 2019
@joohokim1 joohokim1 added this to the 3.2.0 milestone Jan 31, 2019
@joohokim1
Copy link
Contributor

Lots of server code about this issue have been changed.
@paigechoi Could you open a new branch and have the changes of the old branch applied?

@AnnieHwang
Copy link
Contributor

기획서 53페이지에 기획되어 있는 내용 캡쳐해서 올려드릴께요~
image

@minjung-cho 예외사항 기획해서 반영부탁드립니다.

@paigechoi @joohokim1 해당 내용 이후에 [METATRON-1572 : 멀티파일 업로드]를 진행하시면 될 것 같습니다.

paigechoi added a commit that referenced this issue Feb 14, 2019
- Delete unnecessary code in create dataset
- Create datasets with multiple selection of sheets in excel
paigechoi added a commit that referenced this issue Feb 18, 2019
- Use observable when creating multiple datasets
paigechoi added a commit that referenced this issue Feb 18, 2019
@minjung-cho
Copy link

@paigechoi 논의한 내용 기록차 남깁니다

  1. 데이터셋 생성 결과가 떨어지면 팝업 닫힘
  2. 생성 완료 토스트 팝업 삭제
  3. 실패한 건에 대해서만 토스트 띄움. "n개의 데이터셋 생성이 실패하였습니다."

@AnnieHwang 멀티 시트 건은 멀티 파일(TO-BE)로 가는 단계로 생각하고 위와 같이 마무리를 하는 것으로 @paigechoi 님과 얘기 나누었습니다. 참고 부탁드립니다

paigechoi added a commit that referenced this issue Feb 19, 2019
- Do not show alert when dataset creation is successful
- Only show alert when dataset creation fails
paigechoi added a commit that referenced this issue Feb 19, 2019
kaypark-skt pushed a commit that referenced this issue Feb 20, 2019
* #748 Fix multi sheet selection
- Delete unnecessary code in create dataset
- Create datasets with multiple selection of sheets in excel

* #748 Add comments about code

* #748 Add error handling
- Do not show alert when dataset creation is successful
- Only show alert when dataset creation fails

* #748 Add loading bar when creating dataset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@dataprep Component Name : Data preparation enhancement Request Change and Feature Enhancement
Projects
None yet
Development

No branches or pull requests

9 participants