Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2009 dataflow icon error in ie #2020

Merged
merged 2 commits into from
May 8, 2019
Merged

#2009 dataflow icon error in ie #2020

merged 2 commits into from
May 8, 2019

Conversation

paigechoi
Copy link
Contributor

Description

Changed svg icon back to png. For some reason chart in dataflow detail page doesn't support svg icon in IE(11)

Related Issue :

#2009

How Has This Been Tested?

** Check with IE **
Go to dataflow detail -> check if you can see icon
image

Need additional checks?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have added tests to cover my changes.

Additional Context

@paigechoi paigechoi added the @dataprep Component Name : Data preparation label May 8, 2019
@kyungtaak
Copy link
Contributor

run build
deploy to 1

@kyungtaak kyungtaak added the testbed1 Review Test Server 1 label May 8, 2019
@kyungtaak kyungtaak self-requested a review May 8, 2019 10:49
kyungtaak
kyungtaak approved these changes May 8, 2019
View reviewed changes
Copy link
Contributor

@kyungtaak kyungtaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@kyungtaak kyungtaak merged commit bbb5d88 into master May 8, 2019
@alchan-lee alchan-lee deleted the f#2009-dataflow_icon_error_in_ie branch May 22, 2019 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joohokim1 joohokim1 joohokim1 approved these changes

@kyungtaak kyungtaak kyungtaak approved these changes

@eltriny eltriny Awaiting requested review from eltriny

@kaypark-skt kaypark-skt Awaiting requested review from kaypark-skt

Assignees
No one assigned
Labels
@dataprep Component Name : Data preparation testbed1 Review Test Server 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paigechoi @kyungtaak @joohokim1